This is an automated email from the ASF dual-hosted git repository.
amitmiran pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new 6132563 ci: use git submodules for Chart Actions (#14211)
6132563 is described below
commit 61325635da2ee411bd60c3496ffde08f3203c74b
Author: jawabuu <[email protected]>
AuthorDate: Sat Apr 17 19:13:36 2021 +0300
ci: use git submodules for Chart Actions (#14211)
* Add chart-action submodules
* use local github actions for chart actions
* Run actions checkout for local checkout
* Run lint when PR is edited
* Remove path filter and dummy value
* Fix fetch-depth
* Test chart version bump
* Update maintainer to pass validation
* Update maintainer to pass validation
---
.github/actions/chart-releaser-action | 1 +
.github/actions/chart-testing-action | 1 +
.github/workflows/superset-helm-lint.yml | 9 +++++----
.github/workflows/superset-helm-release.yml | 6 ++++--
.gitmodules | 6 ++++++
helm/superset/Chart.yaml | 8 ++++----
helm/superset/values.yaml | 2 --
7 files changed, 21 insertions(+), 12 deletions(-)
diff --git a/.github/actions/chart-releaser-action
b/.github/actions/chart-releaser-action
new file mode 160000
index 0000000..120944e
--- /dev/null
+++ b/.github/actions/chart-releaser-action
@@ -0,0 +1 @@
+Subproject commit 120944e66390c2534cc1b3c62d7285ba7ff02594
diff --git a/.github/actions/chart-testing-action
b/.github/actions/chart-testing-action
new file mode 160000
index 0000000..b0d4458
--- /dev/null
+++ b/.github/actions/chart-testing-action
@@ -0,0 +1 @@
+Subproject commit b0d4458c71155b54fcf33e11dd465dc923550009
diff --git a/.github/workflows/superset-helm-lint.yml
b/.github/workflows/superset-helm-lint.yml
index 2309eaa..272b7c9 100644
--- a/.github/workflows/superset-helm-lint.yml
+++ b/.github/workflows/superset-helm-lint.yml
@@ -2,16 +2,17 @@ name: Lint and Test Charts
on:
pull_request:
- paths:
- - 'helm/**'
+ types: [opened, edited, reopened, synchronize]
jobs:
lint-test:
runs-on: ubuntu-latest
steps:
- - name: Checkout
+ - name: "Checkout ${{ github.ref }} ( ${{ github.sha }} )"
uses: actions/checkout@v2
with:
+ persist-credentials: false
+ submodules: recursive
fetch-depth: 0
- name: Set up Helm
@@ -24,7 +25,7 @@ jobs:
python-version: 3.7
- name: Set up chart-testing
- uses: helm/[email protected]
+ uses: ./.github/actions/chart-testing-action
- name: Run chart-testing (list-changed)
id: list-changed
diff --git a/.github/workflows/superset-helm-release.yml
b/.github/workflows/superset-helm-release.yml
index f69d13e..bf89614 100644
--- a/.github/workflows/superset-helm-release.yml
+++ b/.github/workflows/superset-helm-release.yml
@@ -11,9 +11,11 @@ jobs:
release:
runs-on: ubuntu-latest
steps:
- - name: Checkout
+ - name: "Checkout ${{ github.ref }} ( ${{ github.sha }} )"
uses: actions/checkout@v2
with:
+ persist-credentials: false
+ submodules: recursive
fetch-depth: 0
- name: Configure Git
@@ -27,7 +29,7 @@ jobs:
version: v3.5.4
- name: Run chart-releaser
- uses: helm/[email protected]
+ uses: ./.github/actions/chart-releaser-action
with:
charts_dir: helm
env:
diff --git a/.gitmodules b/.gitmodules
index 768bf2e..002a207 100644
--- a/.gitmodules
+++ b/.gitmodules
@@ -30,3 +30,9 @@
[submodule ".github/actions/comment-on-pr"]
path = .github/actions/comment-on-pr
url = https://github.com/unsplash/comment-on-pr
+[submodule ".github/actions/chart-testing-action"]
+ path = .github/actions/chart-testing-action
+ url = https://github.com/helm/chart-testing-action
+[submodule ".github/actions/chart-releaser-action"]
+ path = .github/actions/chart-releaser-action
+ url = https://github.com/helm/chart-releaser-action
diff --git a/helm/superset/Chart.yaml b/helm/superset/Chart.yaml
index 4937903..a45c9c6 100644
--- a/helm/superset/Chart.yaml
+++ b/helm/superset/Chart.yaml
@@ -19,10 +19,10 @@ appVersion: "1.0"
description: Apache Superset is a modern, enterprise-ready business
intelligence web application
name: superset
maintainers:
- - name: Chuan-Yen Chiang
- email: [email protected]
- url: https://github.com/cychiang
-version: 0.1.0
+ - name: craig-rueda
+ email: [email protected]
+ url: https://github.com/craig-rueda
+version: 0.1.1
dependencies:
- name: postgresql
version: 10.2.0
diff --git a/helm/superset/values.yaml b/helm/superset/values.yaml
index 1c8acd4..1a25419 100644
--- a/helm/superset/values.yaml
+++ b/helm/superset/values.yaml
@@ -372,5 +372,3 @@ nodeSelector: {}
tolerations: []
affinity: {}
-
-dummy: true
