This is an automated email from the ASF dual-hosted git repository. michaelsmolina pushed a commit to branch 3.0 in repository https://gitbox.apache.org/repos/asf/superset.git
commit 42a6846f424782e1f367360805f5187015d93f69 Author: Beto Dealmeida <[email protected]> AuthorDate: Wed Feb 7 14:58:51 2024 -0500 fix: safer error message in alerts (#27019) (cherry picked from commit 686ce33ea5017aad4cca18a6409c00f6b366dcf4) --- superset/reports/commands/alert.py | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/superset/reports/commands/alert.py b/superset/reports/commands/alert.py index 41163dc064..6a5c5cdf71 100644 --- a/superset/reports/commands/alert.py +++ b/superset/reports/commands/alert.py @@ -151,7 +151,7 @@ class AlertCommand(BaseCommand): rendered_sql, ALERT_SQL_LIMIT ) - _, username = get_executor( + executor, username = get_executor( # pylint: disable=unused-variable executor_types=app.config["ALERT_REPORTS_EXECUTE_AS"], model=self._report_schedule, ) @@ -170,7 +170,12 @@ class AlertCommand(BaseCommand): logger.warning("A timeout occurred while executing the alert query: %s", ex) raise AlertQueryTimeout() from ex except Exception as ex: - raise AlertQueryError(message=str(ex)) from ex + logger.exception("An error occurred when running alert query") + # The exception message here can reveal to much information to malicious + # users, so we raise a generic message. + raise AlertQueryError( + message=_("An error occurred when running alert query") + ) from ex def validate(self) -> None: """
