This is an automated email from the ASF dual-hosted git repository.

rusackas pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 5912fad745 fix(dashboard): Fix subitem selection on dashboard download 
menu (#33933)
5912fad745 is described below

commit 5912fad745c33af5fc4733e17d65ab00a321a93e
Author: Erkka Tahvanainen <[email protected]>
AuthorDate: Fri Jul 18 21:16:19 2025 +0300

    fix(dashboard): Fix subitem selection on dashboard download menu (#33933)
    
    Co-authored-by: Erkka Tahvanainen <[email protected]>
---
 .../src/dashboard/components/menu/DownloadMenuItems/DownloadAsImage.tsx | 2 ++
 .../src/dashboard/components/menu/DownloadMenuItems/DownloadAsPdf.tsx   | 2 ++
 2 files changed, 4 insertions(+)

diff --git 
a/superset-frontend/src/dashboard/components/menu/DownloadMenuItems/DownloadAsImage.tsx
 
b/superset-frontend/src/dashboard/components/menu/DownloadMenuItems/DownloadAsImage.tsx
index 1d98b47a20..a992bbb5d4 100644
--- 
a/superset-frontend/src/dashboard/components/menu/DownloadMenuItems/DownloadAsImage.tsx
+++ 
b/superset-frontend/src/dashboard/components/menu/DownloadMenuItems/DownloadAsImage.tsx
@@ -27,6 +27,7 @@ export default function DownloadAsImage({
   text,
   logEvent,
   dashboardTitle,
+  ...props
 }: {
   text: string;
   dashboardTitle: string;
@@ -50,6 +51,7 @@ export default function DownloadAsImage({
       onClick={e => {
         onDownloadImage(e.domEvent);
       }}
+      {...props}
     >
       {text}
     </Menu.Item>
diff --git 
a/superset-frontend/src/dashboard/components/menu/DownloadMenuItems/DownloadAsPdf.tsx
 
b/superset-frontend/src/dashboard/components/menu/DownloadMenuItems/DownloadAsPdf.tsx
index d7ed81b7d5..40fe21e022 100644
--- 
a/superset-frontend/src/dashboard/components/menu/DownloadMenuItems/DownloadAsPdf.tsx
+++ 
b/superset-frontend/src/dashboard/components/menu/DownloadMenuItems/DownloadAsPdf.tsx
@@ -27,6 +27,7 @@ export default function DownloadAsPdf({
   text,
   logEvent,
   dashboardTitle,
+  ...props
 }: {
   text: string;
   dashboardTitle: string;
@@ -50,6 +51,7 @@ export default function DownloadAsPdf({
       onClick={e => {
         onDownloadPdf(e.domEvent);
       }}
+      {...props}
     >
       {text}
     </Menu.Item>

Reply via email to