(superset) 04/06: fix: Update Pie chart control panel to use proper shared controls

[rusackas]

This is an automated email from the ASF dual-hosted git repository.

rusackas pushed a commit to branch move-controls
in repository https://gitbox.apache.org/repos/asf/superset.git

commit cf3b93b7bc6bb0479e5fb616ece21297e86519bb
Author: Evan Rusackas <e...@rusackas.com>
AuthorDate: Thu Aug 14 10:03:05 2025 -0700

    fix: Update Pie chart control panel to use proper shared controls
    
    - Fix groupby and metric control configurations
    - Use spread operator to properly extend shared controls
    - Add proper labels and descriptions for controls
    - Temporarily disable formDataOverrides to debug column issues
    - Fix sort_by_metric control type definition
    
    The 'Referenced columns not available in DataFrame' error should now be 
resolved.
---
 .../src/Pie/controlPanelModern.tsx                 | 42 ++++++++++++++++------
 1 file changed, 31 insertions(+), 11 deletions(-)

diff --git 
a/superset-frontend/plugins/plugin-chart-echarts/src/Pie/controlPanelModern.tsx 
b/superset-frontend/plugins/plugin-chart-echarts/src/Pie/controlPanelModern.tsx
index f600713c74..5f48cd1279 100644
--- 
a/superset-frontend/plugins/plugin-chart-echarts/src/Pie/controlPanelModern.tsx
+++ 
b/superset-frontend/plugins/plugin-chart-echarts/src/Pie/controlPanelModern.tsx
@@ -41,19 +41,30 @@ const config: ControlPanelConfig = {
         [
           {
             name: 'groupby',
-            config: sharedControls.groupby || {},
+            config: {
+              ...sharedControls.groupby,
+              label: t('Group by'),
+              description: t('One or many columns to group by'),
+            },
           },
         ],
         [
           {
             name: 'metric',
-            config: sharedControls.metrics || {},
+            config: {
+              ...sharedControls.metrics,
+              multi: false,
+              label: t('Metric'),
+              description: t('Metric to display in the pie chart'),
+            },
           },
         ],
         [
           {
             name: 'adhoc_filters',
-            config: sharedControls.adhoc_filters || {},
+            config: {
+              ...sharedControls.adhoc_filters,
+            },
           },
         ],
         [
@@ -68,7 +79,13 @@ const config: ControlPanelConfig = {
         [
           {
             name: 'sort_by_metric',
-            config: sharedControls.sort_by_metric || {},
+            config: {
+              type: 'CheckboxControl',
+              label: t('Sort by metric'),
+              default: true,
+              renderTrigger: true,
+              description: t('Sort series by metric values'),
+            },
           },
         ],
       ],
@@ -80,7 +97,9 @@ const config: ControlPanelConfig = {
         [
           {
             name: 'color_scheme',
-            config: sharedControls.color_scheme || {},
+            config: {
+              ...sharedControls.color_scheme,
+            },
           },
         ],
         [
@@ -370,12 +389,13 @@ const config: ControlPanelConfig = {
       ],
     },
   ],
-  formDataOverrides: formData => ({
-    ...formData,
-    metric: getStandardizedControls().shiftMetric(),
-    groupby: getStandardizedControls().popAllColumns(),
-    row_limit: formData.row_limit ?? 100,
-  }),
+  // Temporarily disable formDataOverrides to debug
+  // formDataOverrides: formData => ({
+  //   ...formData,
+  //   metric: getStandardizedControls().shiftMetric(),
+  //   groupby: getStandardizedControls().popAllColumns(),
+  //   row_limit: formData.row_limit ?? 100,
+  // }),
 };
 
 export default config;