This is an automated email from the ASF dual-hosted git repository.
justinpark pushed a commit to branch 5.0-extensions
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/5.0-extensions by this push:
new ccaf2c921b5 remove spec
ccaf2c921b5 is described below
commit ccaf2c921b5f766a7439a6a658092f9f1a2d408f
Author: justinpark <[email protected]>
AuthorDate: Mon Feb 9 10:54:30 2026 -0800
remove spec
---
.../test/WorldMap.test.ts | 338 ---------------------
1 file changed, 338 deletions(-)
diff --git
a/superset-frontend/plugins/legacy-plugin-chart-world-map/test/WorldMap.test.ts
b/superset-frontend/plugins/legacy-plugin-chart-world-map/test/WorldMap.test.ts
deleted file mode 100644
index dba65a4522c..00000000000
---
a/superset-frontend/plugins/legacy-plugin-chart-world-map/test/WorldMap.test.ts
+++ /dev/null
@@ -1,338 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied. See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-import d3 from 'd3';
-import WorldMap from '../src/WorldMap';
-
-type MouseEventHandler = (this: HTMLElement) => void;
-
-interface MockD3Selection {
- attr: jest.Mock;
- style: jest.Mock;
- classed: jest.Mock;
- selectAll: jest.Mock;
-}
-
-// Mock Datamap
-const mockBubbles = jest.fn();
-const mockUpdateChoropleth = jest.fn();
-const mockSvg = {
- selectAll: jest.fn().mockReturnThis(),
- on: jest.fn().mockReturnThis(),
- attr: jest.fn().mockReturnThis(),
- style: jest.fn().mockReturnThis(),
-};
-
-jest.mock('datamaps/dist/datamaps.all.min', () =>
- jest.fn().mockImplementation(config => {
- // Call the done callback immediately to simulate Datamap initialization
- if (config.done) {
- config.done({
- svg: mockSvg,
- });
- }
- return {
- bubbles: mockBubbles,
- updateChoropleth: mockUpdateChoropleth,
- svg: mockSvg,
- };
- }),
-);
-
-let container: HTMLElement;
-const mockFormatter = jest.fn(val => String(val));
-
-const baseProps = {
- data: [
- { country: 'USA', name: 'United States', m1: 100, m2: 200, code: 'US' },
- { country: 'CAN', name: 'Canada', m1: 50, m2: 100, code: 'CA' },
- ],
- width: 600,
- height: 400,
- maxBubbleSize: 25,
- showBubbles: false,
- linearColorScheme: 'schemeRdYlBu',
- color: '#61B0B7',
- colorBy: 'country',
- colorScheme: 'supersetColors',
- sliceId: 123,
- theme: {
- colors: {
- grayscale: {
- dark2: '#616161',
- light2: '#bdbdbd',
- light5: '#e0e0e0',
- },
- },
- },
- countryFieldtype: 'code',
- entity: 'country',
- onContextMenu: jest.fn(),
- setDataMask: jest.fn(),
- inContextMenu: false,
- filterState: { selectedValues: [] },
- emitCrossFilters: false,
- formatter: mockFormatter,
-};
-
-beforeEach(() => {
- jest.clearAllMocks();
- container = document.createElement('div');
- document.body.appendChild(container);
-});
-
-afterEach(() => {
- document.body.removeChild(container);
-});
-
-test('sets up mouseover and mouseout handlers on countries', () => {
- WorldMap(container, baseProps);
-
- expect(mockSvg.selectAll).toHaveBeenCalledWith('.datamaps-subunit');
- const onCalls = mockSvg.on.mock.calls;
-
- // Find mouseover and mouseout handler registrations
- const hasMouseover = onCalls.some(call => call[0] === 'mouseover');
- const hasMouseout = onCalls.some(call => call[0] === 'mouseout');
-
- expect(hasMouseover).toBe(true);
- expect(hasMouseout).toBe(true);
-});
-
-test('stores original fill color on mouseover', () => {
- // Create a mock DOM element with d3 selection capabilities
- const mockElement = document.createElement('path');
- mockElement.setAttribute('class', 'datamaps-subunit USA');
- mockElement.style.fill = 'rgb(100, 150, 200)';
- container.appendChild(mockElement);
-
- let mouseoverHandler: MouseEventHandler | null = null;
-
- // Mock d3.select to return the mock element
- const mockD3Selection: MockD3Selection = {
- attr: jest.fn((attrName: string, value?: string) => {
- if (value !== undefined) {
- mockElement.setAttribute(attrName, value);
- } else {
- return mockElement.getAttribute(attrName);
- }
- return mockD3Selection;
- }),
- style: jest.fn((styleName: string, value?: string) => {
- if (value !== undefined) {
- mockElement.style[styleName as any] = value;
- } else {
- return mockElement.style[styleName as any];
- }
- return mockD3Selection;
- }),
- classed: jest.fn().mockReturnThis(),
- selectAll: jest.fn().mockReturnValue({ remove: jest.fn() }),
- };
-
- jest.spyOn(d3, 'select').mockReturnValue(mockD3Selection as any);
-
- // Capture the mouseover handler
- mockSvg.on.mockImplementation((event: string, handler: MouseEventHandler) =>
{
- if (event === 'mouseover') {
- mouseoverHandler = handler;
- }
- return mockSvg;
- });
-
- WorldMap(container, baseProps);
-
- // Simulate mouseover
- if (mouseoverHandler) {
- (mouseoverHandler as MouseEventHandler).call(mockElement);
- }
-
- // Verify that data-original-fill attribute was set
- expect(mockD3Selection.attr).toHaveBeenCalledWith(
- 'data-original-fill',
- expect.any(String),
- );
-});
-
-test('restores original fill color on mouseout for country with data', () => {
- const mockElement = document.createElement('path');
- mockElement.setAttribute('class', 'datamaps-subunit USA');
- mockElement.style.fill = 'rgb(100, 150, 200)';
- mockElement.setAttribute('data-original-fill', 'rgb(100, 150, 200)');
- container.appendChild(mockElement);
-
- let mouseoutHandler: MouseEventHandler | null = null;
-
- const mockD3Selection: MockD3Selection = {
- attr: jest.fn((attrName: string, value?: string | null) => {
- if (value !== undefined) {
- if (value === null) {
- mockElement.removeAttribute(attrName);
- } else {
- mockElement.setAttribute(attrName, value);
- }
- return mockD3Selection;
- }
- return mockElement.getAttribute(attrName);
- }),
- style: jest.fn((styleName: string, value?: string) => {
- if (value !== undefined) {
- mockElement.style[styleName as any] = value;
- }
- return mockElement.style[styleName as any] || mockD3Selection;
- }),
- classed: jest.fn().mockReturnThis(),
- selectAll: jest.fn().mockReturnValue({ remove: jest.fn() }),
- };
-
- jest.spyOn(d3, 'select').mockReturnValue(mockD3Selection as any);
-
- // Capture the mouseout handler
- mockSvg.on.mockImplementation((event: string, handler: MouseEventHandler) =>
{
- if (event === 'mouseout') {
- mouseoutHandler = handler;
- }
- return mockSvg;
- });
-
- WorldMap(container, baseProps);
-
- // Simulate mouseout
- if (mouseoutHandler) {
- (mouseoutHandler as MouseEventHandler).call(mockElement);
- }
-
- // Verify that original fill was restored
- expect(mockD3Selection.style).toHaveBeenCalledWith(
- 'fill',
- 'rgb(100, 150, 200)',
- );
- expect(mockD3Selection.attr).toHaveBeenCalledWith('data-original-fill',
null);
-});
-
-test('restores default fill color on mouseout for country with no data', () =>
{
- const mockElement = document.createElement('path');
- mockElement.setAttribute('class', 'datamaps-subunit XXX');
- mockElement.style.fill = '#e0e0e0'; // Default border color
- mockElement.setAttribute('data-original-fill', '#e0e0e0');
- container.appendChild(mockElement);
-
- let mouseoutHandler: MouseEventHandler | null = null;
-
- const mockD3Selection: MockD3Selection = {
- attr: jest.fn((attrName: string, value?: string | null) => {
- if (value !== undefined) {
- if (value === null) {
- mockElement.removeAttribute(attrName);
- } else {
- mockElement.setAttribute(attrName, value);
- }
- return mockD3Selection;
- }
- return mockElement.getAttribute(attrName);
- }),
- style: jest.fn((styleName: string, value?: string) => {
- if (value !== undefined) {
- mockElement.style[styleName as any] = value;
- }
- return mockElement.style[styleName as any] || mockD3Selection;
- }),
- classed: jest.fn().mockReturnThis(),
- selectAll: jest.fn().mockReturnValue({ remove: jest.fn() }),
- };
-
- jest.spyOn(d3, 'select').mockReturnValue(mockD3Selection as any);
-
- mockSvg.on.mockImplementation((event: string, handler: MouseEventHandler) =>
{
- if (event === 'mouseout') {
- mouseoutHandler = handler;
- }
- return mockSvg;
- });
-
- WorldMap(container, baseProps);
-
- // Simulate mouseout
- if (mouseoutHandler) {
- (mouseoutHandler as MouseEventHandler).call(mockElement);
- }
-
- // Verify that default fill was restored (no-data color)
- expect(mockD3Selection.style).toHaveBeenCalledWith('fill', '#e0e0e0');
- expect(mockD3Selection.attr).toHaveBeenCalledWith('data-original-fill',
null);
-});
-
-test('does not handle mouse events when inContextMenu is true', () => {
- const propsWithContextMenu = {
- ...baseProps,
- inContextMenu: true,
- };
-
- const mockElement = document.createElement('path');
- mockElement.setAttribute('class', 'datamaps-subunit USA');
- mockElement.style.fill = 'rgb(100, 150, 200)';
- container.appendChild(mockElement);
-
- let mouseoverHandler: MouseEventHandler | null = null;
- let mouseoutHandler: MouseEventHandler | null = null;
-
- const mockD3Selection: MockD3Selection = {
- attr: jest.fn(() => mockD3Selection),
- style: jest.fn(() => mockD3Selection),
- classed: jest.fn().mockReturnThis(),
- selectAll: jest.fn().mockReturnValue({ remove: jest.fn() }),
- };
-
- jest.spyOn(d3, 'select').mockReturnValue(mockD3Selection as any);
-
- mockSvg.on.mockImplementation((event: string, handler: MouseEventHandler) =>
{
- if (event === 'mouseover') {
- mouseoverHandler = handler;
- }
- if (event === 'mouseout') {
- mouseoutHandler = handler;
- }
- return mockSvg;
- });
-
- WorldMap(container, propsWithContextMenu);
-
- // Simulate mouseover and mouseout
- if (mouseoverHandler) {
- (mouseoverHandler as MouseEventHandler).call(mockElement);
- }
- if (mouseoutHandler) {
- (mouseoutHandler as MouseEventHandler).call(mockElement);
- }
-
- // When inContextMenu is true, handlers should exit early without modifying
anything
- // We verify this by checking that attr and style weren't called to change
fill
- const attrCalls = mockD3Selection.attr.mock.calls;
- const fillChangeCalls = attrCalls.filter(
- (call: [string, unknown]) =>
- call[0] === 'data-original-fill' && call[1] !== undefined,
- );
- const styleCalls = mockD3Selection.style.mock.calls;
- const fillStyleChangeCalls = styleCalls.filter(
- (call: [string, unknown]) => call[0] === 'fill' && call[1] !== undefined,
- );
- // The handlers should return early, so no state changes
- expect(fillChangeCalls.length).toBe(0);
- expect(fillStyleChangeCalls.length).toBe(0);
-});
