This is an automated email from the ASF dual-hosted git repository.
rusackas pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new 26b6f7bb5df fix(dashboard): preserve refresh_frequency when absent
from save data (#42354)
26b6f7bb5df is described below
commit 26b6f7bb5df8fad7b62ef08fa6bc4e9b6ee67bc7
Author: PRATHAMESH HUKKERI <[email protected]>
AuthorDate: Tue Jul 28 11:43:11 2026 +0530
fix(dashboard): preserve refresh_frequency when absent from save data
(#42354)
Co-authored-by: Prathamesh Hukkeri <[email protected]>
---
superset/daos/dashboard.py | 3 +-
tests/unit_tests/dao/dashboard_test.py | 51 ++++++++++++++++++++++++++++++++++
2 files changed, 53 insertions(+), 1 deletion(-)
diff --git a/superset/daos/dashboard.py b/superset/daos/dashboard.py
index 4afa24edac8..40267df21ca 100644
--- a/superset/daos/dashboard.py
+++ b/superset/daos/dashboard.py
@@ -397,7 +397,8 @@ class DashboardDAO(BaseDAO[Dashboard]):
md["color_namespace"] = data.get("color_namespace")
md["expanded_slices"] = data.get("expanded_slices", {})
- md["refresh_frequency"] = data.get("refresh_frequency", 0)
+ if "refresh_frequency" in data:
+ md["refresh_frequency"] = data["refresh_frequency"]
md["color_scheme"] = data.get("color_scheme", "")
md["label_colors"] = data.get("label_colors", {})
md["shared_label_colors"] = data.get("shared_label_colors", [])
diff --git a/tests/unit_tests/dao/dashboard_test.py
b/tests/unit_tests/dao/dashboard_test.py
index b9694ee0d51..a263e8807e2 100644
--- a/tests/unit_tests/dao/dashboard_test.py
+++ b/tests/unit_tests/dao/dashboard_test.py
@@ -24,6 +24,7 @@ from superset.connectors.sqla.models import Database,
SqlaTable
from superset.daos.dashboard import DashboardDAO
from superset.models.dashboard import Dashboard
from superset.models.slice import Slice
+from superset.utils import json
from tests.unit_tests.conftest import with_feature_flags
@@ -117,3 +118,53 @@ def test_set_dash_metadata_preserves_soft_deleted_members(
)
# And the position slot kept its UUID rather than being nulled.
assert positions["CHART-trashed"]["meta"]["uuid"] ==
str(trashed_chart.uuid)
+
+
+def test_set_dash_metadata_preserves_refresh_frequency(session: Session) ->
None:
+ """set_dash_metadata must not reset refresh_frequency when absent from
data.
+
+ Regression test for #42116: ``data.get("refresh_frequency", 0)`` would
+ unconditionally overwrite the existing value with 0 whenever the caller
+ did not include ``refresh_frequency`` in the data dict.
+ """
+ Dashboard.metadata.create_all(session.get_bind())
+
+ dashboard = Dashboard(
+ dashboard_title="refresh_test_dash",
+ json_metadata=json.dumps({"refresh_frequency": 30}),
+ )
+ db.session.add(dashboard)
+ db.session.flush()
+
+ # Simulate a save that does NOT include refresh_frequency
+ # (e.g. changing only the title via the PropertiesModal).
+ DashboardDAO.set_dash_metadata(dashboard, {"color_scheme": "superset"})
+
+ md = json.loads(dashboard.json_metadata)
+ assert md["refresh_frequency"] == 30, (
+ "refresh_frequency should be preserved when not present in data"
+ )
+
+
+def test_set_dash_metadata_updates_refresh_frequency_when_present(
+ session: Session,
+) -> None:
+ """set_dash_metadata must update refresh_frequency when it IS in data."""
+ Dashboard.metadata.create_all(session.get_bind())
+
+ dashboard = Dashboard(
+ dashboard_title="refresh_test_dash_2",
+ json_metadata=json.dumps({"refresh_frequency": 30}),
+ )
+ db.session.add(dashboard)
+ db.session.flush()
+
+ # Simulate a save that explicitly sets refresh_frequency to 0.
+ DashboardDAO.set_dash_metadata(
+ dashboard, {"refresh_frequency": 0, "color_scheme": "superset"}
+ )
+
+ md = json.loads(dashboard.json_metadata)
+ assert md["refresh_frequency"] == 0, (
+ "refresh_frequency should be updated when present in data"
+ )
