This is an automated email from the ASF dual-hosted git repository.
sadpandajoe pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new 30584517b5b fix(mypy): type-check dataset export in full-tree mypy
(#45616)
30584517b5b is described below
commit 30584517b5bfb57b8ba62b7d405be404d584eecc
Author: Joe Li <[email protected]>
AuthorDate: Fri Oct 23 10:18:17 2026 -0700
fix(mypy): type-check dataset export in full-tree mypy (#45616)
Co-authored-by: Claude Opus 5.5 <[email protected]>
---
pyproject.toml | 1 +
superset/commands/export/assets.py | 2 +-
tests/unit_tests/commands/chart/export_test.py | 2 +-
3 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/pyproject.toml b/pyproject.toml
index 8b148ffc82f..df2b709f276 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -424,6 +424,7 @@ module = [
"superset.daos.datasource",
"superset.commands.security.reset",
"tests.unit_tests.commands.deletion_retention.test_purge_chart_detach",
+ "tests.unit_tests.commands.chart.export_test",
]
warn_unused_ignores = false
diff --git a/superset/commands/export/assets.py
b/superset/commands/export/assets.py
index 5e2ee7ad975..1a3814fcb13 100644
--- a/superset/commands/export/assets.py
+++ b/superset/commands/export/assets.py
@@ -154,7 +154,7 @@ class ExportAssetsCommand(BaseCommand):
list(candidate_ids), skip_visibility_filter=True
)
}
- return sorted(referenced - set(dataset_ids))
+ return sorted(referenced.difference(dataset_ids))
def validate(self) -> None:
pass
diff --git a/tests/unit_tests/commands/chart/export_test.py
b/tests/unit_tests/commands/chart/export_test.py
index 15fe4ffe181..136f055da3e 100644
--- a/tests/unit_tests/commands/chart/export_test.py
+++ b/tests/unit_tests/commands/chart/export_test.py
@@ -400,7 +400,7 @@ def
test_assets_export_carries_the_soft_deleted_datasets_it_references(
db.session.flush()
restored = db.session.query(SqlaTable).filter(
- SqlaTable.uuid.in_([dataset.uuid, filter_dataset.uuid])
+ SqlaTable.uuid.in_([dataset.uuid, filter_dataset.uuid]) # type:
ignore[union-attr]
)
assert {str(table.uuid) for table in restored if table.deleted_at is None}
== (
trashed_uuids