This is an automated email from the ASF dual-hosted git repository.

johnbodley pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new c1187e0  [cache] Adding description for a zero cache timeout (#5354)
c1187e0 is described below

commit c1187e0eaadbab7b39c2c7c2ae7c76954a3fefe6
Author: John Bodley <4567245+john-bod...@users.noreply.github.com>
AuthorDate: Fri Jul 6 09:24:21 2018 -0700

    [cache] Adding description for a zero cache timeout (#5354)
---
 superset/connectors/druid/views.py | 2 ++
 superset/connectors/sqla/views.py  | 1 +
 superset/views/core.py             | 1 +
 3 files changed, 4 insertions(+)

diff --git a/superset/connectors/druid/views.py 
b/superset/connectors/druid/views.py
index 9a33c8d..7e50536 100644
--- a/superset/connectors/druid/views.py
+++ b/superset/connectors/druid/views.py
@@ -179,6 +179,7 @@ class DruidClusterModelView(SupersetModelView, DeleteMixin, 
YamlExportMixin):  #
     description_columns = {
         'cache_timeout': _(
             'Duration (in seconds) of the caching timeout for this cluster. '
+            'A timeout of 0 indicates that the cache never expires. '
             'Note this defaults to the global timeout if undefined.'),
     }
 
@@ -256,6 +257,7 @@ class DruidDatasourceModelView(DatasourceModelView, 
DeleteMixin, YamlExportMixin
             'from the datasource list'),
         'cache_timeout': _(
             'Duration (in seconds) of the caching timeout for this datasource. 
'
+            'A timeout of 0 indicates that the cache never expires. '
             'Note this defaults to the cluster timeout if undefined.'),
     }
     base_filters = [['id', DatasourceFilter, lambda: []]]
diff --git a/superset/connectors/sqla/views.py 
b/superset/connectors/sqla/views.py
index b8349e5..d4149fc 100644
--- a/superset/connectors/sqla/views.py
+++ b/superset/connectors/sqla/views.py
@@ -221,6 +221,7 @@ class TableModelView(DatasourceModelView, DeleteMixin, 
YamlExportMixin):  # noqa
             'Jinja templating syntax'),
         'cache_timeout': _(
             'Duration (in seconds) of the caching timeout for this table. '
+            'A timeout of 0 indicates that the cache never expires. '
             'Note this defaults to the database timeout if undefined.'),
     }
     label_columns = {
diff --git a/superset/views/core.py b/superset/views/core.py
index bddc544..6d7d7bc 100755
--- a/superset/views/core.py
+++ b/superset/views/core.py
@@ -268,6 +268,7 @@ class DatabaseView(SupersetModelView, DeleteMixin, 
YamlExportMixin):  # noqa
             'tables, this can be expensive and put strain on the system.'),
         'cache_timeout': _(
             'Duration (in seconds) of the caching timeout for this database. '
+            'A timeout of 0 indicates that the cache never expires. '
             'Note this defaults to the global timeout if undefined.'),
     }
     label_columns = {

Reply via email to