This is an automated email from the ASF dual-hosted git repository. maximebeauchemin pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-superset.git
The following commit(s) were added to refs/heads/master by this push: new 08cdb09 [explore] raise attention to row_limit being reached (#6252) 08cdb09 is described below commit 08cdb097140516883e3b1a4a0f4fe987e5f72a8a Author: Maxime Beauchemin <maximebeauche...@gmail.com> AuthorDate: Mon Nov 5 08:31:44 2018 -0800 [explore] raise attention to row_limit being reached (#6252) * [explore] raise attention to row_limit being reached * fix test --- .../assets/spec/javascripts/explore/components/RowCountLabel_spec.jsx | 4 ++-- superset/assets/src/explore/components/RowCountLabel.jsx | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/superset/assets/spec/javascripts/explore/components/RowCountLabel_spec.jsx b/superset/assets/spec/javascripts/explore/components/RowCountLabel_spec.jsx index 761f2e1..4f06da3 100644 --- a/superset/assets/spec/javascripts/explore/components/RowCountLabel_spec.jsx +++ b/superset/assets/spec/javascripts/explore/components/RowCountLabel_spec.jsx @@ -20,12 +20,12 @@ describe('RowCountLabel', () => { expect(wrapper.find(Label)).toHaveLength(1); expect(wrapper.find(TooltipWrapper)).toHaveLength(1); }); - it('renders a warning when limit is reached', () => { + it('renders a danger when limit is reached', () => { const props = { rowcount: 100, limit: 100, }; const wrapper = shallow(<RowCountLabel {...props} />); - expect(wrapper.find(Label).first().props().bsStyle).toBe('warning'); + expect(wrapper.find(Label).first().props().bsStyle).toBe('danger'); }); }); diff --git a/superset/assets/src/explore/components/RowCountLabel.jsx b/superset/assets/src/explore/components/RowCountLabel.jsx index 1ba2102..aea9bc4 100644 --- a/superset/assets/src/explore/components/RowCountLabel.jsx +++ b/superset/assets/src/explore/components/RowCountLabel.jsx @@ -20,7 +20,7 @@ const defaultProps = { export default function RowCountLabel({ rowcount, limit, suffix }) { const limitReached = rowcount === limit; - const bsStyle = (limitReached || rowcount === 0) ? 'warning' : 'default'; + const bsStyle = (limitReached || rowcount === 0) ? 'danger' : 'default'; const formattedRowCount = defaultNumberFormatter(rowcount); const tooltip = ( <span>