This is an automated email from the ASF dual-hosted git repository. maximebeauchemin pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-superset.git
The following commit(s) were added to refs/heads/master by this push: new c653ab1 Fix Infinity css warning (#6280) c653ab1 is described below commit c653ab1e9bbc2eb132f4e223b18ab5a4fb568480 Author: Maxime Beauchemin <maximebeauche...@gmail.com> AuthorDate: Mon Nov 5 22:39:42 2018 -0800 Fix Infinity css warning (#6280) --- .../src/dashboard/components/resizable/ResizableContainer.jsx | 6 ++++-- superset/assets/src/visualizations/deckgl/DeckGLContainer.jsx | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/superset/assets/src/dashboard/components/resizable/ResizableContainer.jsx b/superset/assets/src/dashboard/components/resizable/ResizableContainer.jsx index 7e09e73..884a549 100644 --- a/superset/assets/src/dashboard/components/resizable/ResizableContainer.jsx +++ b/superset/assets/src/dashboard/components/resizable/ResizableContainer.jsx @@ -7,6 +7,8 @@ import ResizableHandle from './ResizableHandle'; import resizableConfig from '../../util/resizableConfig'; import { GRID_BASE_UNIT, GRID_GUTTER_SIZE } from '../../util/constants'; +const proxyToInfinity = Number.MAX_VALUE; + const propTypes = { id: PropTypes.string.isRequired, children: PropTypes.node, @@ -41,9 +43,9 @@ const defaultProps = { widthMultiple: null, heightMultiple: null, minWidthMultiple: 1, - maxWidthMultiple: Infinity, + maxWidthMultiple: proxyToInfinity, minHeightMultiple: 1, - maxHeightMultiple: Infinity, + maxHeightMultiple: proxyToInfinity, staticHeight: null, staticHeightMultiple: null, staticWidth: null, diff --git a/superset/assets/src/visualizations/deckgl/DeckGLContainer.jsx b/superset/assets/src/visualizations/deckgl/DeckGLContainer.jsx index 435a541..2c86277 100644 --- a/superset/assets/src/visualizations/deckgl/DeckGLContainer.jsx +++ b/superset/assets/src/visualizations/deckgl/DeckGLContainer.jsx @@ -38,7 +38,7 @@ export default class DeckGLContainer extends React.Component { })); } componentWillUnmount() { - this.clearInterval(this.state.timer); + clearInterval(this.state.timer); } onViewportChange(viewport) { const vp = Object.assign({}, viewport);