This is an automated email from the ASF dual-hosted git repository.
maximebeauchemin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git
The following commit(s) were added to refs/heads/master by this push:
new b44c834 [bugfix] EventFlow does not display (#6367)
b44c834 is described below
commit b44c8349eef43153c59fcf1f1aa19b4c9f015096
Author: James Finucane <jnishiy...@users.noreply.github.com>
AuthorDate: Mon Nov 12 20:41:21 2018 +0200
[bugfix] EventFlow does not display (#6367)
* Fix EventFlow transform is not a function
transformProps was being passed into EventFlowChartPlugin as object
(module) as opposed to function. This commit changes the implementation to be
consistent with the other ChartPlugins and fixes the typeError that causes
EventFlow Chart to not display.
* Revert to lazy-loading transformProps
- Revert to lazy-loading transformProps
- Fix in Superchart will default to transformProps.default if available to
allow for the lazy-loading
* Fix for lazy-loaded imports in ChartPlugins
* Fix lint error
---
superset/assets/src/visualizations/core/components/SuperChart.jsx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/superset/assets/src/visualizations/core/components/SuperChart.jsx
b/superset/assets/src/visualizations/core/components/SuperChart.jsx
index a8b9214..4361b1a 100644
--- a/superset/assets/src/visualizations/core/components/SuperChart.jsx
+++ b/superset/assets/src/visualizations/core/components/SuperChart.jsx
@@ -84,7 +84,7 @@ class SuperChart extends React.PureComponent {
renderChart(loaded, props) {
const Chart = loaded.Chart.default || loaded.Chart;
- const transformProps = loaded.transformProps;
+ const transformProps = loaded.transformProps.default ||
loaded.transformProps;
const {
chartProps,
preTransformProps,
