Author: indika
Date: Wed Feb 24 10:25:00 2010
New Revision: 915741
URL: http://svn.apache.org/viewvc?rev=915741&view=rev
Log:
doing some minor refactoring on comments and code
Modified:
synapse/trunk/java/modules/commons/src/main/java/org/apache/synapse/commons/evaluators/And.java
synapse/trunk/java/modules/commons/src/main/java/org/apache/synapse/commons/evaluators/Equal.java
synapse/trunk/java/modules/commons/src/main/java/org/apache/synapse/commons/evaluators/EvaluatorConstants.java
synapse/trunk/java/modules/commons/src/main/java/org/apache/synapse/commons/evaluators/Match.java
synapse/trunk/java/modules/commons/src/main/java/org/apache/synapse/commons/evaluators/Not.java
synapse/trunk/java/modules/commons/src/main/java/org/apache/synapse/commons/evaluators/Or.java
synapse/trunk/java/modules/commons/src/main/java/org/apache/synapse/commons/evaluators/Parser.java
synapse/trunk/java/modules/commons/src/main/java/org/apache/synapse/commons/evaluators/config/EvaluatorFactory.java
Modified:
synapse/trunk/java/modules/commons/src/main/java/org/apache/synapse/commons/evaluators/And.java
URL:
http://svn.apache.org/viewvc/synapse/trunk/java/modules/commons/src/main/java/org/apache/synapse/commons/evaluators/And.java?rev=915741&r1=915740&r2=915741&view=diff
==============================================================================
---
synapse/trunk/java/modules/commons/src/main/java/org/apache/synapse/commons/evaluators/And.java
(original)
+++
synapse/trunk/java/modules/commons/src/main/java/org/apache/synapse/commons/evaluators/And.java
Wed Feb 24 10:25:00 2010
@@ -41,7 +41,7 @@
}
public String getName() {
- return "and";
+ return EvaluatorConstants.AND;
}
public void setEvaluators(Evaluator[] evaluators) {
Modified:
synapse/trunk/java/modules/commons/src/main/java/org/apache/synapse/commons/evaluators/Equal.java
URL:
http://svn.apache.org/viewvc/synapse/trunk/java/modules/commons/src/main/java/org/apache/synapse/commons/evaluators/Equal.java?rev=915741&r1=915740&r2=915741&view=diff
==============================================================================
---
synapse/trunk/java/modules/commons/src/main/java/org/apache/synapse/commons/evaluators/Equal.java
(original)
+++
synapse/trunk/java/modules/commons/src/main/java/org/apache/synapse/commons/evaluators/Equal.java
Wed Feb 24 10:25:00 2010
@@ -60,7 +60,7 @@
}
public String getName() {
- return "equal";
+ return EvaluatorConstants.EQUAL;
}
public void setValue(String value) {
Modified:
synapse/trunk/java/modules/commons/src/main/java/org/apache/synapse/commons/evaluators/EvaluatorConstants.java
URL:
http://svn.apache.org/viewvc/synapse/trunk/java/modules/commons/src/main/java/org/apache/synapse/commons/evaluators/EvaluatorConstants.java?rev=915741&r1=915740&r2=915741&view=diff
==============================================================================
---
synapse/trunk/java/modules/commons/src/main/java/org/apache/synapse/commons/evaluators/EvaluatorConstants.java
(original)
+++
synapse/trunk/java/modules/commons/src/main/java/org/apache/synapse/commons/evaluators/EvaluatorConstants.java
Wed Feb 24 10:25:00 2010
@@ -19,6 +19,9 @@
package org.apache.synapse.commons.evaluators;
+/**
+ * Constants used through out the evaluators
+ */
public class EvaluatorConstants {
public static final String PRIORITY = "priority";
public static final String VALUE = "value";
Modified:
synapse/trunk/java/modules/commons/src/main/java/org/apache/synapse/commons/evaluators/Match.java
URL:
http://svn.apache.org/viewvc/synapse/trunk/java/modules/commons/src/main/java/org/apache/synapse/commons/evaluators/Match.java?rev=915741&r1=915740&r2=915741&view=diff
==============================================================================
---
synapse/trunk/java/modules/commons/src/main/java/org/apache/synapse/commons/evaluators/Match.java
(original)
+++
synapse/trunk/java/modules/commons/src/main/java/org/apache/synapse/commons/evaluators/Match.java
Wed Feb 24 10:25:00 2010
@@ -68,7 +68,7 @@
}
public String getName() {
- return "match";
+ return EvaluatorConstants.MATCH;
}
public int getType() {
Modified:
synapse/trunk/java/modules/commons/src/main/java/org/apache/synapse/commons/evaluators/Not.java
URL:
http://svn.apache.org/viewvc/synapse/trunk/java/modules/commons/src/main/java/org/apache/synapse/commons/evaluators/Not.java?rev=915741&r1=915740&r2=915741&view=diff
==============================================================================
---
synapse/trunk/java/modules/commons/src/main/java/org/apache/synapse/commons/evaluators/Not.java
(original)
+++
synapse/trunk/java/modules/commons/src/main/java/org/apache/synapse/commons/evaluators/Not.java
Wed Feb 24 10:25:00 2010
@@ -35,7 +35,7 @@
}
public String getName() {
- return "not";
+ return EvaluatorConstants.NOT;
}
public void setEvaluator(Evaluator evaluator) {
Modified:
synapse/trunk/java/modules/commons/src/main/java/org/apache/synapse/commons/evaluators/Or.java
URL:
http://svn.apache.org/viewvc/synapse/trunk/java/modules/commons/src/main/java/org/apache/synapse/commons/evaluators/Or.java?rev=915741&r1=915740&r2=915741&view=diff
==============================================================================
---
synapse/trunk/java/modules/commons/src/main/java/org/apache/synapse/commons/evaluators/Or.java
(original)
+++
synapse/trunk/java/modules/commons/src/main/java/org/apache/synapse/commons/evaluators/Or.java
Wed Feb 24 10:25:00 2010
@@ -41,7 +41,7 @@
}
public String getName() {
- return "or";
+ return EvaluatorConstants.OR;
}
public void setEvaluators(Evaluator[] evaluators) {
Modified:
synapse/trunk/java/modules/commons/src/main/java/org/apache/synapse/commons/evaluators/Parser.java
URL:
http://svn.apache.org/viewvc/synapse/trunk/java/modules/commons/src/main/java/org/apache/synapse/commons/evaluators/Parser.java?rev=915741&r1=915740&r2=915741&view=diff
==============================================================================
---
synapse/trunk/java/modules/commons/src/main/java/org/apache/synapse/commons/evaluators/Parser.java
(original)
+++
synapse/trunk/java/modules/commons/src/main/java/org/apache/synapse/commons/evaluators/Parser.java
Wed Feb 24 10:25:00 2010
@@ -45,10 +45,16 @@
public class Parser {
private Log log = LogFactory.getLog(Parser.class);
+ /** set of conditions to be evaluated */
private Condition[] conditions = null;
+ /** Default priority to be used */
private int defaultPriority = -1;
+ /**
+ * Create a parser with the defualt priority set to -1. If a HTTP message
+ * doesn't obey any of the conditions parser will return -1.
+ */
public Parser() {
}
Modified:
synapse/trunk/java/modules/commons/src/main/java/org/apache/synapse/commons/evaluators/config/EvaluatorFactory.java
URL:
http://svn.apache.org/viewvc/synapse/trunk/java/modules/commons/src/main/java/org/apache/synapse/commons/evaluators/config/EvaluatorFactory.java?rev=915741&r1=915740&r2=915741&view=diff
==============================================================================
---
synapse/trunk/java/modules/commons/src/main/java/org/apache/synapse/commons/evaluators/config/EvaluatorFactory.java
(original)
+++
synapse/trunk/java/modules/commons/src/main/java/org/apache/synapse/commons/evaluators/config/EvaluatorFactory.java
Wed Feb 24 10:25:00 2010
@@ -25,7 +25,7 @@
import org.apache.axiom.om.OMElement;
/**
- * Interface for creating a evaluator.
+ * This should be implemented by all the Factories creating an evaluators.
*/
public interface EvaluatorFactory {
