This is an automated email from the ASF dual-hosted git repository.

ilgrosso pushed a commit to branch 4_1_X
in repository https://gitbox.apache.org/repos/asf/syncope.git

commit 6f04fca71b550c9df1f4a47ed8218bfa027e25fb
Author: Francesco Chicchiriccò <[email protected]>
AuthorDate: Wed Nov 11 14:46:55 2026 +0100

    Ensure to find users by eq token
---
 .../syncope/core/persistence/jpa/dao/repo/UserRepo.java      |  2 +-
 .../apache/syncope/core/persistence/jpa/inner/UserTest.java  | 12 ++++++++++++
 .../syncope/core/persistence/neo4j/inner/UserTest.java       | 12 ++++++++++++
 3 files changed, 25 insertions(+), 1 deletion(-)

diff --git 
a/core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/dao/repo/UserRepo.java
 
b/core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/dao/repo/UserRepo.java
index 846521afea..eede54f051 100644
--- 
a/core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/dao/repo/UserRepo.java
+++ 
b/core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/dao/repo/UserRepo.java
@@ -40,7 +40,7 @@ public interface UserRepo
     @Override
     Optional<String> findUsername(@Param("key") String key);
 
-    @Query("SELECT e FROM #{#entityName} e WHERE e.token LIKE :token")
+    @Query("SELECT e FROM #{#entityName} e WHERE e.token = :token")
     @Override
     Optional<? extends User> findByToken(@Param("token") String token);
 
diff --git 
a/core/persistence-jpa/src/test/java/org/apache/syncope/core/persistence/jpa/inner/UserTest.java
 
b/core/persistence-jpa/src/test/java/org/apache/syncope/core/persistence/jpa/inner/UserTest.java
index 29dc05d80d..ced7326d95 100644
--- 
a/core/persistence-jpa/src/test/java/org/apache/syncope/core/persistence/jpa/inner/UserTest.java
+++ 
b/core/persistence-jpa/src/test/java/org/apache/syncope/core/persistence/jpa/inner/UserTest.java
@@ -90,6 +90,18 @@ public class UserTest extends AbstractTest {
     @Test
     public void findByToken() {
         assertTrue(userDAO.findByToken("WRONG TOKEN").isEmpty());
+
+        User user = 
userDAO.findById("823074dc-d280-436d-a7dd-07399fae48ec").orElseThrow();
+        user.generateToken(32, 60);
+        user = userDAO.save(user);
+
+        String token = user.getToken();
+        assertEquals(user.getKey(), 
userDAO.findByToken(token).orElseThrow().getKey());
+
+        // wildcards must not be interpreted as such, or tokens could be 
guessed character by character
+        assertTrue(userDAO.findByToken(token.substring(0, token.length() - 1) 
+ "%").isEmpty());
+        assertTrue(userDAO.findByToken("%").isEmpty());
+        assertTrue(userDAO.findByToken("_").isEmpty());
     }
 
     @Test
diff --git 
a/core/persistence-neo4j/src/test/java/org/apache/syncope/core/persistence/neo4j/inner/UserTest.java
 
b/core/persistence-neo4j/src/test/java/org/apache/syncope/core/persistence/neo4j/inner/UserTest.java
index b49c015746..a04c6a20a5 100644
--- 
a/core/persistence-neo4j/src/test/java/org/apache/syncope/core/persistence/neo4j/inner/UserTest.java
+++ 
b/core/persistence-neo4j/src/test/java/org/apache/syncope/core/persistence/neo4j/inner/UserTest.java
@@ -90,6 +90,18 @@ public class UserTest extends AbstractTest {
     @Test
     public void findByToken() {
         assertTrue(userDAO.findByToken("WRONG TOKEN").isEmpty());
+
+        User user = 
userDAO.findById("823074dc-d280-436d-a7dd-07399fae48ec").orElseThrow();
+        user.generateToken(32, 60);
+        user = userDAO.save(user);
+
+        String token = user.getToken();
+        assertEquals(user.getKey(), 
userDAO.findByToken(token).orElseThrow().getKey());
+
+        // wildcards must not be interpreted as such, or tokens could be 
guessed character by character
+        assertTrue(userDAO.findByToken(token.substring(0, token.length() - 1) 
+ "%").isEmpty());
+        assertTrue(userDAO.findByToken("%").isEmpty());
+        assertTrue(userDAO.findByToken("_").isEmpty());
     }
 
     @Test

Reply via email to