This is an automated email from the ASF dual-hosted git repository. ilgrosso pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/syncope.git
commit 66f372123885a3f24b2ee6cae511c33e1c77baed Author: Francesco Chicchiriccò <[email protected]> AuthorDate: Wed Nov 11 14:48:28 2026 +0100 Ensure to find users by eq token --- .../core/persistence/jpa/dao/repo/UserRepoExtImpl.java | 2 +- .../apache/syncope/core/persistence/jpa/inner/UserTest.java | 12 ++++++++++++ .../syncope/core/persistence/neo4j/inner/UserTest.java | 12 ++++++++++++ 3 files changed, 25 insertions(+), 1 deletion(-) diff --git a/core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/dao/repo/UserRepoExtImpl.java b/core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/dao/repo/UserRepoExtImpl.java index 8fa4c6f927..59ca4532e3 100644 --- a/core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/dao/repo/UserRepoExtImpl.java +++ b/core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/dao/repo/UserRepoExtImpl.java @@ -100,7 +100,7 @@ public class UserRepoExtImpl extends AbstractAnyRepoExt<User> implements UserRep @Override public Optional<String> findByToken(final String token) { return query( - "SELECT id FROM " + JPAUser.TABLE + " WHERE token LIKE ?", + "SELECT id FROM " + JPAUser.TABLE + " WHERE token = ?", rs -> { if (rs.next()) { return Optional.of(rs.getString(1)); diff --git a/core/persistence-jpa/src/test/java/org/apache/syncope/core/persistence/jpa/inner/UserTest.java b/core/persistence-jpa/src/test/java/org/apache/syncope/core/persistence/jpa/inner/UserTest.java index 29dc05d80d..bd853dee7a 100644 --- a/core/persistence-jpa/src/test/java/org/apache/syncope/core/persistence/jpa/inner/UserTest.java +++ b/core/persistence-jpa/src/test/java/org/apache/syncope/core/persistence/jpa/inner/UserTest.java @@ -90,6 +90,18 @@ public class UserTest extends AbstractTest { @Test public void findByToken() { assertTrue(userDAO.findByToken("WRONG TOKEN").isEmpty()); + + User user = userDAO.findById("823074dc-d280-436d-a7dd-07399fae48ec").orElseThrow(); + user.generateToken(32, 60); + user = userDAO.save(user); + + String token = user.getToken(); + assertEquals(user.getKey(), userDAO.findByToken(token).orElseThrow()); + + // wildcards must not be interpreted as such, or tokens could be guessed character by character + assertTrue(userDAO.findByToken(token.substring(0, token.length() - 1) + "%").isEmpty()); + assertTrue(userDAO.findByToken("%").isEmpty()); + assertTrue(userDAO.findByToken("_").isEmpty()); } @Test diff --git a/core/persistence-neo4j/src/test/java/org/apache/syncope/core/persistence/neo4j/inner/UserTest.java b/core/persistence-neo4j/src/test/java/org/apache/syncope/core/persistence/neo4j/inner/UserTest.java index b49c015746..7554af6e65 100644 --- a/core/persistence-neo4j/src/test/java/org/apache/syncope/core/persistence/neo4j/inner/UserTest.java +++ b/core/persistence-neo4j/src/test/java/org/apache/syncope/core/persistence/neo4j/inner/UserTest.java @@ -90,6 +90,18 @@ public class UserTest extends AbstractTest { @Test public void findByToken() { assertTrue(userDAO.findByToken("WRONG TOKEN").isEmpty()); + + User user = userDAO.findById("823074dc-d280-436d-a7dd-07399fae48ec").orElseThrow(); + user.generateToken(32, 60); + user = userDAO.save(user); + + String token = user.getToken(); + assertEquals(user.getKey(), userDAO.findByToken(token).orElseThrow()); + + // wildcards must not be interpreted as such, or tokens could be guessed character by character + assertTrue(userDAO.findByToken(token.substring(0, token.length() - 1) + "%").isEmpty()); + assertTrue(userDAO.findByToken("%").isEmpty()); + assertTrue(userDAO.findByToken("_").isEmpty()); } @Test
