[systemds] branch master updated: [MINOR] Fix flaky lineage cache eviction test (robustness github test)

[mboehm7]

This is an automated email from the ASF dual-hosted git repository.

mboehm7 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/systemds.git


The following commit(s) were added to refs/heads/master by this push:
     new 538f547  [MINOR] Fix flaky lineage cache eviction test (robustness 
github test)
538f547 is described below

commit 538f5472e13bbb011baa0bddee887807396bb45c
Author: Matthias Boehm <mboe...@gmail.com>
AuthorDate: Sat Dec 19 22:45:40 2020 +0100

    [MINOR] Fix flaky lineage cache eviction test (robustness github test)
---
 .../org/apache/sysds/test/functions/lineage/CacheEvictionTest.java  | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git 
a/src/test/java/org/apache/sysds/test/functions/lineage/CacheEvictionTest.java 
b/src/test/java/org/apache/sysds/test/functions/lineage/CacheEvictionTest.java
index ac23d2e..c2b79d3 100644
--- 
a/src/test/java/org/apache/sysds/test/functions/lineage/CacheEvictionTest.java
+++ 
b/src/test/java/org/apache/sysds/test/functions/lineage/CacheEvictionTest.java
@@ -129,7 +129,10 @@ public class CacheEvictionTest extends LineageBase {
                        Assert.assertTrue(expCount_lru >= expCount_wt);
                        // Compare counts of evicted items
                        // LRU tends to evict more entries to recover equal 
amount of memory
-                       Assert.assertTrue(evictedCount_lru > evictedCount_wt);
+                       // Note: changed to equals to fix flaky tests where 
both are not evicted at all
+                       // (e.g., due to high execution time as sometimes 
observed through github actions)
+                       Assert.assertTrue(("Violated expected evictions: 
"+evictedCount_lru+" >= "+evictedCount_wt),
+                               evictedCount_lru >= evictedCount_wt);
                        // Compare cache hits
                        Assert.assertTrue(hitCount_lru < hitCount_wt);
                }
@@ -139,5 +142,4 @@ public class CacheEvictionTest extends LineageBase {
                        Recompiler.reinitRecompiler();
                }
        }
-
 }