This is an automated email from the ASF dual-hosted git repository. baunsgaard pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/systemds.git
commit 614c168624aed8d007a9d391790d610b78c45fcb Author: baunsgaard <[email protected]> AuthorDate: Mon Apr 12 10:09:50 2021 +0200 [MINOR] Increase timeout to 90 minues for function tests This commit also contain a change in the component test to not fail if the spark context is closed with exception. This has no read consequences except for executing all tests locally, then in the off chance that this test does not the spark context, the tests will fail. Closes #1223 --- .github/workflows/functionsTests.yml | 2 +- .../sysds/test/component/convert/RDDConverterUtilsExtTest.java | 10 +++++++--- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/.github/workflows/functionsTests.yml b/.github/workflows/functionsTests.yml index 70d2af1..a121ff2 100644 --- a/.github/workflows/functionsTests.yml +++ b/.github/workflows/functionsTests.yml @@ -32,7 +32,7 @@ on: jobs: applicationsTests: runs-on: ${{ matrix.os }} - timeout-minutes: 60 + timeout-minutes: 90 strategy: fail-fast: false matrix: diff --git a/src/test/java/org/apache/sysds/test/component/convert/RDDConverterUtilsExtTest.java b/src/test/java/org/apache/sysds/test/component/convert/RDDConverterUtilsExtTest.java index 94df587..0b58d61 100644 --- a/src/test/java/org/apache/sysds/test/component/convert/RDDConverterUtilsExtTest.java +++ b/src/test/java/org/apache/sysds/test/component/convert/RDDConverterUtilsExtTest.java @@ -153,8 +153,12 @@ public class RDDConverterUtilsExtTest extends AutomatedTestBase { public static void tearDownClass() { // stop spark context to allow single jvm tests (otherwise the // next test that tries to create a SparkContext would fail) - sc.stop(); - sc = null; - conf = null; + try{ + sc.stop(); + } + finally{ + sc = null; + conf = null; + } } }
