[systemds] branch main updated: [SYSTEMDS-3315] Fix lineage exploitation in the buffer pool

[arnabp20]

This is an automated email from the ASF dual-hosted git repository.

arnabp20 pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/systemds.git


The following commit(s) were added to refs/heads/main by this push:
     new 9f91eab  [SYSTEMDS-3315] Fix lineage exploitation in the buffer pool
9f91eab is described below

commit 9f91eab7695460bd38fe4cc54d4290360d390f62
Author: arnabp <arnab.ph...@tugraz.at>
AuthorDate: Sat Mar 12 18:18:53 2022 +0100

    [SYSTEMDS-3315] Fix lineage exploitation in the buffer pool
---
 .../org/apache/sysds/runtime/controlprogram/caching/MatrixObject.java  | 3 ++-
 .../test/functions/lineage/LineageExploitationBufferPoolTest.java      | 3 +--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git 
a/src/main/java/org/apache/sysds/runtime/controlprogram/caching/MatrixObject.java
 
b/src/main/java/org/apache/sysds/runtime/controlprogram/caching/MatrixObject.java
index ffedd65..b09b295 100644
--- 
a/src/main/java/org/apache/sysds/runtime/controlprogram/caching/MatrixObject.java
+++ 
b/src/main/java/org/apache/sysds/runtime/controlprogram/caching/MatrixObject.java
@@ -54,6 +54,7 @@ import org.apache.sysds.runtime.meta.MetaDataFormat;
 import org.apache.sysds.runtime.util.DataConverter;
 import org.apache.sysds.runtime.util.HDFSTool;
 import org.apache.sysds.runtime.util.IndexRange;
+import org.apache.sysds.utils.Explain;
 
 /**
  * Represents a matrix in control program. This class contains method to read 
matrices from HDFS and convert them to a
@@ -580,7 +581,7 @@ public class MatrixObject extends 
CacheableData<MatrixBlock> {
 
        @Override
        protected MatrixBlock reconstructByLineage(LineageItem li) throws 
IOException {
-               return ((MatrixObject) 
LineageRecomputeUtils.parseNComputeLineageTrace(li.getData(), null))
+               return ((MatrixObject) 
LineageRecomputeUtils.parseNComputeLineageTrace(Explain.explain(li), null))
                        .acquireReadAndRelease();
        }
 }
diff --git 
a/src/test/java/org/apache/sysds/test/functions/lineage/LineageExploitationBufferPoolTest.java
 
b/src/test/java/org/apache/sysds/test/functions/lineage/LineageExploitationBufferPoolTest.java
index 3e6ed72..7126396 100644
--- 
a/src/test/java/org/apache/sysds/test/functions/lineage/LineageExploitationBufferPoolTest.java
+++ 
b/src/test/java/org/apache/sysds/test/functions/lineage/LineageExploitationBufferPoolTest.java
@@ -54,8 +54,7 @@ public class LineageExploitationBufferPoolTest extends 
LineageBase
 
                        LOG.debug("------------ BEGIN " + testname + 
"------------");
 
-                       /* Test description
-                        */
+                       // TODO: Simulate memory pressure to test recompute 
matrix from lineage.
 
                        OptimizerUtils.ALLOW_ALGEBRAIC_SIMPLIFICATION = false;
                        OptimizerUtils.ALLOW_SUM_PRODUCT_REWRITES = false;