This is an automated email from the ASF dual-hosted git repository.
arnabp20 pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/systemds.git
The following commit(s) were added to refs/heads/main by this push:
new 952ed0089b [MINOR] Remove duplicate tests for countDistinct
952ed0089b is described below
commit 952ed0089be2744becf973a408c08c879cd55893
Author: Badrul Chowdhury <[email protected]>
AuthorDate: Tue Nov 1 08:56:51 2022 +0100
[MINOR] Remove duplicate tests for countDistinct
This patch removes duplicate tests for countDistinct builtin
Closes #1719
---
.../countDistinct/CountDistinctApproxCol.java | 102 ---------------------
.../countDistinct/CountDistinctApproxRow.java | 102 ---------------------
2 files changed, 204 deletions(-)
diff --git
a/src/test/java/org/apache/sysds/test/functions/countDistinct/CountDistinctApproxCol.java
b/src/test/java/org/apache/sysds/test/functions/countDistinct/CountDistinctApproxCol.java
deleted file mode 100644
index 69f5fa1ef1..0000000000
---
a/src/test/java/org/apache/sysds/test/functions/countDistinct/CountDistinctApproxCol.java
+++ /dev/null
@@ -1,102 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied. See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-package org.apache.sysds.test.functions.countDistinct;
-
-import org.apache.sysds.common.Types;
-import org.apache.sysds.runtime.data.SparseBlock;
-import org.junit.Test;
-
-public class CountDistinctApproxCol extends CountDistinctRowOrColBase {
-
- private final static String TEST_NAME = "countDistinctApproxCol";
- private final static String TEST_DIR = "functions/countDistinctApprox/";
- private final static String TEST_CLASS_DIR = TEST_DIR +
CountDistinctApproxCol.class.getSimpleName() + "/";
-
- @Override
- protected String getTestClassDir() {
- return TEST_CLASS_DIR;
- }
-
- @Override
- protected String getTestName() {
- return TEST_NAME;
- }
-
- @Override
- protected String getTestDir() {
- return TEST_DIR;
- }
-
- @Override
- protected Types.Direction getDirection() {
- return Types.Direction.Col;
- }
-
- @Override
- public void setUp() {
- super.addTestConfiguration();
- }
-
- @Test
- public void testCPSparseLargeDefaultMCSR() {
- Types.ExecType ex = Types.ExecType.CP;
-
- int actualDistinctCount = 10;
- int rows = 1000, cols = 10000;
- double sparsity = 0.1;
- double tolerance = actualDistinctCount * this.percentTolerance;
-
- countDistinctMatrixTest(getDirection(), actualDistinctCount,
cols, rows, sparsity, ex, tolerance);
- }
-
- @Test
- public void testCPSparseLargeCSR() {
- int actualDistinctCount = 10;
- int rows = 1000, cols = 10000;
- double sparsity = 0.1;
- double tolerance = actualDistinctCount * this.percentTolerance;
-
- super.testCPSparseLarge(SparseBlock.Type.CSR,
Types.Direction.Col, rows, cols, actualDistinctCount, sparsity,
- tolerance);
- }
-
- @Test
- public void testCPSparseLargeCOO() {
- int actualDistinctCount = 10;
- int rows = 1000, cols = 10000;
- double sparsity = 0.1;
- double tolerance = actualDistinctCount * this.percentTolerance;
-
- super.testCPSparseLarge(SparseBlock.Type.COO,
Types.Direction.Col, rows, cols, actualDistinctCount, sparsity,
- tolerance);
- }
-
- @Test
- public void testCPDenseLarge() {
- Types.ExecType ex = Types.ExecType.CP;
-
- int actualDistinctCount = 100;
- int rows = 1000, cols = 10000;
- double sparsity = 0.9;
- double tolerance = actualDistinctCount * this.percentTolerance;
-
- countDistinctMatrixTest(getDirection(), actualDistinctCount,
cols, rows, sparsity, ex, tolerance);
- }
-}
diff --git
a/src/test/java/org/apache/sysds/test/functions/countDistinct/CountDistinctApproxRow.java
b/src/test/java/org/apache/sysds/test/functions/countDistinct/CountDistinctApproxRow.java
deleted file mode 100644
index 07f3fcac38..0000000000
---
a/src/test/java/org/apache/sysds/test/functions/countDistinct/CountDistinctApproxRow.java
+++ /dev/null
@@ -1,102 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied. See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-package org.apache.sysds.test.functions.countDistinct;
-
-import org.apache.sysds.common.Types;
-import org.apache.sysds.runtime.data.SparseBlock;
-import org.junit.Test;
-
-public class CountDistinctApproxRow extends CountDistinctRowOrColBase {
-
- private final static String TEST_NAME = "countDistinctApproxRow";
- private final static String TEST_DIR = "functions/countDistinctApprox/";
- private final static String TEST_CLASS_DIR = TEST_DIR +
CountDistinctApproxRow.class.getSimpleName() + "/";
-
- @Override
- protected String getTestClassDir() {
- return TEST_CLASS_DIR;
- }
-
- @Override
- protected String getTestName() {
- return TEST_NAME;
- }
-
- @Override
- protected String getTestDir() {
- return TEST_DIR;
- }
-
- @Override
- protected Types.Direction getDirection() {
- return Types.Direction.Row;
- }
-
- @Override
- public void setUp() {
- super.addTestConfiguration();
- }
-
- @Test
- public void testCPSparseLargeDefaultMCSR() {
- Types.ExecType ex = Types.ExecType.CP;
-
- int actualDistinctCount = 10;
- int rows = 10000, cols = 1000;
- double sparsity = 0.1;
- double tolerance = actualDistinctCount * this.percentTolerance;
-
- countDistinctMatrixTest(getDirection(), actualDistinctCount,
cols, rows, sparsity, ex, tolerance);
- }
-
- @Test
- public void testCPSparseLargeCSR() {
- int actualDistinctCount = 10;
- int rows = 10000, cols = 1000;
- double sparsity = 0.1;
- double tolerance = actualDistinctCount * this.percentTolerance;
-
- super.testCPSparseLarge(SparseBlock.Type.CSR,
Types.Direction.Row, rows, cols, actualDistinctCount, sparsity,
- tolerance);
- }
-
- @Test
- public void testCPSparseLargeCOO() {
- int actualDistinctCount = 10;
- int rows = 10000, cols = 1000;
- double sparsity = 0.1;
- double tolerance = actualDistinctCount * this.percentTolerance;
-
- super.testCPSparseLarge(SparseBlock.Type.COO,
Types.Direction.Row, rows, cols, actualDistinctCount, sparsity,
- tolerance);
- }
-
- @Test
- public void testCPDenseLarge() {
- Types.ExecType ex = Types.ExecType.CP;
-
- int actualDistinctCount = 100;
- int rows = 10000, cols = 1000;
- double sparsity = 0.9;
- double tolerance = actualDistinctCount * this.percentTolerance;
-
- countDistinctMatrixTest(getDirection(), actualDistinctCount,
cols, rows, sparsity, ex, tolerance);
- }
-}
