[systemds] branch main updated: [SYSTEMDS-3038] CLA Spark Left Multiplication

[baunsgaard]

This is an automated email from the ASF dual-hosted git repository.

baunsgaard pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/systemds.git


The following commit(s) were added to refs/heads/main by this push:
     new 10315ab806 [SYSTEMDS-3038] CLA Spark Left Multiplication
10315ab806 is described below

commit 10315ab806d91ed3b40ab4ae3b243181c5e87050
Author: baunsgaard <baunsga...@tu-berlin.de>
AuthorDate: Tue May 30 11:56:12 2023 +0200

    [SYSTEMDS-3038] CLA Spark Left Multiplication
    
    This commit reenable a test that was disabled for Spark LMM.
    This was disabled because previously we were unable to stack compressed
    matrices, while now we can. and therefore we can do Spark Left MM
    compressed.
---
 .../functions/compress/configuration/CompressForce.java   | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

diff --git 
a/src/test/java/org/apache/sysds/test/functions/compress/configuration/CompressForce.java
 
b/src/test/java/org/apache/sysds/test/functions/compress/configuration/CompressForce.java
index 76e861769f..2429024699 100644
--- 
a/src/test/java/org/apache/sysds/test/functions/compress/configuration/CompressForce.java
+++ 
b/src/test/java/org/apache/sysds/test/functions/compress/configuration/CompressForce.java
@@ -19,6 +19,8 @@
 
 package org.apache.sysds.test.functions.compress.configuration;
 
+import static org.junit.Assert.fail;
+
 import java.io.File;
 
 import org.apache.sysds.common.Types.ExecType;
@@ -189,7 +191,7 @@ public class CompressForce extends CompressBase {
                // be aware that with multiple blocks it is likely that the 
small blocks
                // initially compress, but is to large for overlapping state 
therefor will decompress.
                // In this test it decompress the second small block but keeps 
the first in overlapping state.
-               compressTest(1110, 10, 1.0, ExecType.SPARK, 1, 6, 1, 1, 1, 
"mmr_sum_plus_2");
+               compressTest(1110, 10, 1.0, ExecType.SPARK, 1, 6, 1, 1, 2, 
"mmr_sum_plus_2");
        }
 
        @Test
@@ -198,10 +200,15 @@ public class CompressForce extends CompressBase {
        }
 
        @Test
-       @Ignore
+       // @Ignore
        public void testMatrixMultLeftSum_SP_SmallerThanLeft() {
-               // see task: https://issues.apache.org/jira/browse/SYSTEMDS-3038
-               runTest(1500, 1, 0, 1, ExecType.SPARK, "mml_sum");
+               try{
+                       runTest(1500, 1, 2, 1, ExecType.SPARK, "mml_sum");
+               }
+               catch(Exception e){
+                       e.printStackTrace();
+                       fail(e.getMessage());
+               }
        }
 
        @Test