(systemds) branch main updated: [MINOR] Fix Integer overflow in Metadata for rows and cols

[baunsgaard]

This is an automated email from the ASF dual-hosted git repository.

baunsgaard pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/systemds.git


The following commit(s) were added to refs/heads/main by this push:
     new efc843fab2 [MINOR] Fix Integer overflow in Metadata for rows and cols
efc843fab2 is described below

commit efc843fab24ea305c4274f8b71a95eb1e61c0db3
Author: Sebastian Baunsgaard <baunsga...@apache.org>
AuthorDate: Fri Jan 5 12:47:23 2024 +0100

    [MINOR] Fix Integer overflow in Metadata for rows and cols
---
 src/main/java/org/apache/sysds/runtime/meta/MetaDataAll.java | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/main/java/org/apache/sysds/runtime/meta/MetaDataAll.java 
b/src/main/java/org/apache/sysds/runtime/meta/MetaDataAll.java
index 43d8ac3840..60730ed960 100644
--- a/src/main/java/org/apache/sysds/runtime/meta/MetaDataAll.java
+++ b/src/main/java/org/apache/sysds/runtime/meta/MetaDataAll.java
@@ -165,8 +165,8 @@ public class MetaDataAll extends DataIdentifier {
        private void parseMetaDataParam(Object key, Object val)
        {
                switch(key.toString()) {
-                       case DataExpression.READROWPARAM: _dim1 = (Integer) 
val; break;
-                       case DataExpression.READCOLPARAM: _dim2 = (Integer) 
val; break;
+                       case DataExpression.READROWPARAM: _dim1 = val 
instanceof Long ? (Long) val : (Integer) val; break;
+                       case DataExpression.READCOLPARAM: _dim2 = val 
instanceof Long ? (Long) val : (Integer) val; break;
                        case DataExpression.ROWBLOCKCOUNTPARAM: 
setBlocksize((Integer) val); break;
                        case DataExpression.READNNZPARAM: setNnz(val instanceof 
Long ? (Long) val : (Integer) val); break;
                        case DataExpression.FORMAT_TYPE: 
setFormatTypeString((String) val); break;
@@ -238,6 +238,8 @@ public class MetaDataAll extends DataIdentifier {
        }
 
        public void setDelim(String delim) {
+               if(delim.length() == 0)
+                       throw new RuntimeException("Invalid metadata delim, 
cannot be empty string");
                _delim = delim;
        }