This is an automated email from the ASF dual-hosted git repository.
janardhan pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/systemds.git
The following commit(s) were added to refs/heads/main by this push:
new 4742a8545d [SYSTEMDS-3672] GIO Test Cases false positive (#1999)
4742a8545d is described below
commit 4742a8545d4af6121aaace00f8ea12b6051ef05d
Author: Saeed Fathollahzadeh <[email protected]>
AuthorDate: Sat Feb 24 10:21:52 2024 -0500
[SYSTEMDS-3672] GIO Test Cases false positive (#1999)
---
.../iogen/FrameGenerateReaderCustomTest.java | 2 +-
.../functions/iogen/FrameGenerateReaderXMLTest.java | 2 +-
.../test/functions/iogen/GenerateReaderFrameTest.java | 5 +----
.../functions/iogen/GenerateReaderMatrixTest.java | 19 +------------------
.../functions/iogen/MatrixGenerateReaderMMTest.java | 2 +-
5 files changed, 5 insertions(+), 25 deletions(-)
diff --git
a/src/test/java/org/apache/sysds/test/functions/iogen/FrameGenerateReaderCustomTest.java
b/src/test/java/org/apache/sysds/test/functions/iogen/FrameGenerateReaderCustomTest.java
index 13c39b864e..e4fbad422f 100644
---
a/src/test/java/org/apache/sysds/test/functions/iogen/FrameGenerateReaderCustomTest.java
+++
b/src/test/java/org/apache/sysds/test/functions/iogen/FrameGenerateReaderCustomTest.java
@@ -23,7 +23,7 @@ import org.junit.Test;
public class FrameGenerateReaderCustomTest extends GenerateReaderFrameTest {
- private final static String TEST_NAME = "FrameGenerateReaderCSVTest";
+ private final static String TEST_NAME = "FrameGenerateReaderCustomTest";
@Override
protected String getTestName() {
diff --git
a/src/test/java/org/apache/sysds/test/functions/iogen/FrameGenerateReaderXMLTest.java
b/src/test/java/org/apache/sysds/test/functions/iogen/FrameGenerateReaderXMLTest.java
index 25c32ead70..c9e17bcb69 100644
---
a/src/test/java/org/apache/sysds/test/functions/iogen/FrameGenerateReaderXMLTest.java
+++
b/src/test/java/org/apache/sysds/test/functions/iogen/FrameGenerateReaderXMLTest.java
@@ -23,7 +23,7 @@ import org.junit.Test;
public class FrameGenerateReaderXMLTest extends GenerateReaderFrameTest {
- private final static String TEST_NAME = "FrameGenerateReaderJSONTest";
+ private final static String TEST_NAME = "FrameGenerateReaderXMLTest";
@Override
protected String getTestName() {
diff --git
a/src/test/java/org/apache/sysds/test/functions/iogen/GenerateReaderFrameTest.java
b/src/test/java/org/apache/sysds/test/functions/iogen/GenerateReaderFrameTest.java
index 8679a8059c..bf9f9ed4da 100644
---
a/src/test/java/org/apache/sysds/test/functions/iogen/GenerateReaderFrameTest.java
+++
b/src/test/java/org/apache/sysds/test/functions/iogen/GenerateReaderFrameTest.java
@@ -71,12 +71,9 @@ public abstract class GenerateReaderFrameTest extends
AutomatedTestBase {
parallel);
FrameReader fr = gr.getReader();
fr.readFrameFromHDFS(dataFileName, sampleSchema, rows,
sampleSchema.length);
-
- // TODO Verify the frameblock contains the correct
values.
-
}
catch(Exception exception) {
- exception.printStackTrace();
+ throw new RuntimeException(exception);
}
finally {
rtplatform = oldPlatform;
diff --git
a/src/test/java/org/apache/sysds/test/functions/iogen/GenerateReaderMatrixTest.java
b/src/test/java/org/apache/sysds/test/functions/iogen/GenerateReaderMatrixTest.java
index ec122d7a35..ad50a22ea0 100644
---
a/src/test/java/org/apache/sysds/test/functions/iogen/GenerateReaderMatrixTest.java
+++
b/src/test/java/org/apache/sysds/test/functions/iogen/GenerateReaderMatrixTest.java
@@ -33,9 +33,6 @@ public abstract class GenerateReaderMatrixTest extends
AutomatedTestBase {
protected final static String TEST_DIR = "functions/iogen/";
protected final static String TEST_CLASS_DIR = TEST_DIR +
GenerateReaderMatrixTest.class.getSimpleName() + "/";
- protected String sampleRaw;
- protected double[][] sampleMatrix;
-
protected abstract String getTestName();
@Override
@@ -44,20 +41,6 @@ public abstract class GenerateReaderMatrixTest extends
AutomatedTestBase {
addTestConfiguration(getTestName(), new
TestConfiguration(TEST_DIR, getTestName(), new String[] {"Y"}));
}
- protected void generateRandomSymmetric(int size, double min, double
max, double sparsity, boolean isSkew) {
- sampleMatrix = getRandomMatrix(size, size, min, max, sparsity,
714);
- int conf = isSkew ? -1 : 1;
- for(int i = 0; i < size; i++) {
- for(int j = 0; j <= i; j++) {
-
- if(i != j)
- sampleMatrix[i][j] = sampleMatrix[j][i]
* conf;
- else
- sampleMatrix[i][j] = 0;
- }
- }
- }
-
@SuppressWarnings("unused")
protected void runGenerateReaderTest(String sampleRawFileName, String
sampleMatrixFileName, boolean parallel) {
@@ -90,7 +73,7 @@ public abstract class GenerateReaderMatrixTest extends
AutomatedTestBase {
}
catch(Exception exception) {
- exception.printStackTrace();
+ throw new RuntimeException(exception);
}
finally {
rtplatform = oldPlatform;
diff --git
a/src/test/java/org/apache/sysds/test/functions/iogen/MatrixGenerateReaderMMTest.java
b/src/test/java/org/apache/sysds/test/functions/iogen/MatrixGenerateReaderMMTest.java
index 2cbb699e6b..e9cc1c8a06 100644
---
a/src/test/java/org/apache/sysds/test/functions/iogen/MatrixGenerateReaderMMTest.java
+++
b/src/test/java/org/apache/sysds/test/functions/iogen/MatrixGenerateReaderMMTest.java
@@ -23,7 +23,7 @@ import org.junit.Test;
public class MatrixGenerateReaderMMTest extends GenerateReaderMatrixTest {
- private final static String TEST_NAME = "FrameGenerateReaderLibSVMTest";
+ private final static String TEST_NAME = "MatrixGenerateReaderMMTest";
@Override
protected String getTestName() {
