This is an automated email from the ASF dual-hosted git repository.
baunsgaard pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/systemds.git
The following commit(s) were added to refs/heads/main by this push:
new aa4ce0ba24 [MINOR] BinaryOp change to switch statement
aa4ce0ba24 is described below
commit aa4ce0ba242b459b4ac99b9017e9812cc2268a45
Author: Sebastian Baunsgaard <[email protected]>
AuthorDate: Mon Feb 3 18:23:29 2025 +0100
[MINOR] BinaryOp change to switch statement
---
src/main/java/org/apache/sysds/hops/BinaryOp.java | 51 ++++++++++++++++++-----
1 file changed, 40 insertions(+), 11 deletions(-)
diff --git a/src/main/java/org/apache/sysds/hops/BinaryOp.java
b/src/main/java/org/apache/sysds/hops/BinaryOp.java
index 839ce641af..d8e57bb0b3 100644
--- a/src/main/java/org/apache/sysds/hops/BinaryOp.java
+++ b/src/main/java/org/apache/sysds/hops/BinaryOp.java
@@ -1154,20 +1154,49 @@ public class BinaryOp extends MultiThreadedHop {
}
public boolean supportsMatrixScalarOperations() {
- return ( op==OpOp2.PLUS ||op==OpOp2.MINUS
- ||op==OpOp2.MULT ||op==OpOp2.DIV
- ||op==OpOp2.MODULUS ||op==OpOp2.INTDIV
- ||op==OpOp2.LESS ||op==OpOp2.LESSEQUAL
- ||op==OpOp2.GREATER ||op==OpOp2.GREATEREQUAL
- ||op==OpOp2.EQUAL ||op==OpOp2.NOTEQUAL
- ||op==OpOp2.MIN ||op==OpOp2.MAX
- ||op==OpOp2.LOG ||op==OpOp2.POW
- ||op==OpOp2.AND ||op==OpOp2.OR ||op==OpOp2.XOR
- ||op==OpOp2.BITWAND ||op==OpOp2.BITWOR
||op==OpOp2.BITWXOR
- ||op==OpOp2.BITWSHIFTL ||op==OpOp2.BITWSHIFTR);
+ switch(op) {
+ case PLUS:
+ case MINUS:
+ case MULT:
+ case DIV:
+ case MODULUS:
+ case INTDIV:
+ case LESS:
+ case LESSEQUAL:
+ case GREATER:
+ case GREATEREQUAL:
+ case EQUAL:
+ case NOTEQUAL:
+ case MIN:
+ case MAX:
+ case LOG:
+ case POW:
+ case AND:
+ case OR:
+ case XOR:
+ case BITWAND:
+ case BITWOR:
+ case BITWXOR:
+ case BITWSHIFTL:
+ case BITWSHIFTR:
+ return true;
+ default:
+ return false;
+ }
}
public boolean isPPredOperation() {
+ switch(op){
+ case LESS:
+ case LESSEQUAL:
+ case GREATER:
+ case GREATEREQUAL:
+ case EQUAL:
+ case NOTEQUAL:
+ return true;
+ default :
+ return false;
+ }
return (op==OpOp2.LESS ||op==OpOp2.LESSEQUAL
||op==OpOp2.GREATER ||op==OpOp2.GREATEREQUAL
||op==OpOp2.EQUAL ||op==OpOp2.NOTEQUAL);
