(systemds) branch main updated: [SYSTEMDS-3696] Improved incremental SliceLine (better size pruning)

[mboehm7]

This is an automated email from the ASF dual-hosted git repository.

mboehm7 pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/systemds.git


The following commit(s) were added to refs/heads/main by this push:
     new 0db61596ee [SYSTEMDS-3696] Improved incremental SliceLine (better size 
pruning)
0db61596ee is described below

commit 0db61596ee42211c34745fcde63ccf69db6567eb
Author: Matthias Boehm <mboe...@gmail.com>
AuthorDate: Mon Mar 3 13:01:20 2025 +0100

    [SYSTEMDS-3696] Improved incremental SliceLine (better size pruning)
    
    This patch slightly changes the new unchanged slice size pruning.
    Instead of checking the old size for unchanged slices, we now
    compare the number of new tuples plus the old size to the min-support
    threshold, which increases its applicability.
---
 scripts/builtin/incSliceLine.dml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/builtin/incSliceLine.dml b/scripts/builtin/incSliceLine.dml
index e0f5c061b5..4dea804740 100644
--- a/scripts/builtin/incSliceLine.dml
+++ b/scripts/builtin/incSliceLine.dml
@@ -688,8 +688,8 @@ pruneUnchangedSlices = function(Matrix[Double] S, 
Matrix[Double] S2, Matrix[Doub
   # Imat has a 1 where a slice in changedX2 belongs to a slice in 
prevLatAtLevel
   if(nrow(S2) > 0 & sum(S2) > 0 & nrow(unchangedS) > 0) {
     # b) select unchanged slices that can be pruned
-    I = t(colSums((changedX2 %*% t(unchangedS)) == level) == 0) # change 
pushdown
-        & unchangedR[,4] < minSup; # minSup pushdown
+    I = t(colSums((changedX2 %*% t(unchangedS)) == level)) # change pushdown
+        + unchangedR[,4] < minSup; # minSup pushdown
     unchangedS2 = removeEmpty(target=unchangedS, margin="rows", select=I);
     if(sum(I) > 0){
       SPr = removeEmpty(target=prevLattice, margin="rows", select=I);