Author: jkuhnert
Date: Wed Dec 20 13:50:53 2006
New Revision: 489206

URL: http://svn.apache.org/viewvc?view=rev&rev=489206
Log:
Fixes a pretty large bug in the Autcompleter component. 

I wasn't correctly using the "<let>" javascript template function to make my 
javascript variable names 
unique and I wasn't passing getClientId() as the component to update for the 
Autocompleter filter url.
 

Modified:
    
tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/dojo/form/Autocompleter.java
    
tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/dojo/form/Autocompleter.script

Modified: 
tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/dojo/form/Autocompleter.java
URL: 
http://svn.apache.org/viewvc/tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/dojo/form/Autocompleter.java?view=diff&rev=489206&r1=489205&r2=489206
==============================================================================
--- 
tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/dojo/form/Autocompleter.java
 (original)
+++ 
tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/dojo/form/Autocompleter.java
 Wed Dec 20 13:50:53 2006
@@ -245,7 +245,7 @@
     public List getUpdateComponents()
     {
         List comps = new ArrayList();
-        comps.add(getId());
+        comps.add(getClientId());
         
         return comps;
     }

Modified: 
tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/dojo/form/Autocompleter.script
URL: 
http://svn.apache.org/viewvc/tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/dojo/form/Autocompleter.script?view=diff&rev=489206&r1=489205&r2=489206
==============================================================================
--- 
tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/dojo/form/Autocompleter.script
 (original)
+++ 
tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/dojo/form/Autocompleter.script
 Wed Dec 20 13:50:53 2006
@@ -7,21 +7,23 @@
 <input-symbol key="props" required="yes" />
 <input-symbol key="form" required="yes" />
 <input-symbol key="widget" required="yes" />
+<let key="completer" unique="yes">
+${id}
+</let>
     <body>
         <unique>
             dojo.require("dojo.widget.Manager");
             dojo.require("dojo.widget.Select");
-            
             dojo.require("tapestry.widget.Widget");
         </unique>
     </body>
     <initialization>
-        var ${id}prop=${props};
-        tapestry.widget.synchronizeWidgetState("${id}", "Select", ${id}prop, 
${widget.destroy});
-        if (${id}prop["label"] &amp;&amp; ${id}prop["value"]){
+        var ${completer}=${props};
+        tapestry.widget.synchronizeWidgetState("${id}", "Select", 
${completer}, ${widget.destroy});
+        if (${completer}["label"] &amp;&amp; ${completer}["value"]){
             var selw=dojo.widget.byId("${id}");
-            selw.setValue(${id}prop["value"]);
-            selw.setLabel(${id}prop["label"]);
+            selw.setValue(${completer}["value"]);
+            selw.setLabel(${completer}["label"]);
         }
     </initialization>
 </script>


Reply via email to