[
https://issues.apache.org/jira/browse/TAP5-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12699272#action_12699272
]
Fernando commented on TAP5-646:
-------------------------------
Totally makes sense that this would be the bug ( if it's true ). I would vote
to me extra secure and add: "\n;"
This way the javascript parser will definitely close any previous statement.. (
either through the return, or through the extra semi-colon ).
> When Tapestry is combining JavaScript files, it should check for a JS file
> that ends with an unterminated comment, and add the comment terminator
> -------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: TAP5-646
> URL: https://issues.apache.org/jira/browse/TAP5-646
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.1.0.4
> Reporter: Howard M. Lewis Ship
> Priority: Minor
>
> From the mailing list:
> I'm found were is the problem...
> It's appear only when tapestry.production-mode=true.
> As I'm understand in this mode all JavaScripts gather in one virtual .js.
> But one of my script have comment at the last line!!!!!
> The next script added to the end of previous one without CL, so the meaning
> line of the second script became commented...
> I'm solve the problem, but IMHO it's need to change virtual file gathering
> in order to prevent such a situation.
> To be honest, this one goes to user error, but the unterminated comment
> doesn't cause problems with many individual <script> tags, just with the
> virtual combined script, so I guess it falls in Tapestry's lap.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
