[ 
https://issues.apache.org/jira/browse/TAP5-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13133456#comment-13133456
 ] 

Steve Eynon commented on TAP5-1677:
-----------------------------------

Just to say I like what's been done and the dev discussion is quite 
interesting...

...besides that am I allowed to say you missed one?  :)

[T5.3-beta-24]

org.apache.tapestry5.corelib.components.Errors.java

@Parameter(name = "class")
private String className = CSSClassConstants.ERROR;

And I guess other parameter usages from CSSClassConstants should be converted 
too.

My use-case: I'm skinning an app with the Twitter Bootstrap CSS framework which 
dictates which CSS names I can use. Being able to specify the class names for 
the Errors (and others) in one place would be of great use.


                
> Use Symbols for Default Component Parameter Values
> --------------------------------------------------
>
>                 Key: TAP5-1677
>                 URL: https://issues.apache.org/jira/browse/TAP5-1677
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: tapestry-core
>    Affects Versions: 5.3
>            Reporter: Steve Eynon
>            Assignee: Massimo Lusetti
>            Priority: Minor
>             Fix For: 5.3
>
>
> For example, the Grid component has the following:
> @Parameter("25")
> private int rowsPerPage;
> meaning if I wish for a pagination of 50 rows, I have to find all instances 
> of the Grid component in my application and manually add a "rowsPerPage" 
> parameter.
> But if the parameter was defined as:
> @Parameter("symbol:tapestry.grid.rowsPerPage")
> private int rowsPerPage;
> then all I would need to do is override the symbol contribution and voilĂ , it 
> changes throughout the whole application.
> Other specific component defaults that would be nice are, the "update" 
> parameter for Zone et al (because the classic "yellow fade" doesn't work for 
> everyone!) and a date format for DateField.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to