[
https://issues.apache.org/jira/browse/TAP5-1791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13248461#comment-13248461
]
Howard M. Lewis Ship edited comment on TAP5-1791 at 4/6/12 4:16 PM:
--------------------------------------------------------------------
Hm. I added a quick test for this:
/**
* And thanks to our friends at Lithium: TAP5-1791
*/
@Test
public void can_handle_extreme_regular_expression()
{
Request request = mockRequest();
String path =
"/user/UserResetPasswordPage/user-id/22/reset-password-token/bHLQiMR3VD6eFTQ7Txj2y4u_HyGKiHwC9bF6dazuuf3__qhKpK3rtSbZHwB6W2dbmGCmPS1By1uq-rcZXO-Ooxd6Ire1vwPpxXUAlx3Mf15ShvJEf8r9MfWEMATS3Pyr-HaGiqqcjN2IhDtJtxnypanQkBrVPMC_APwDp7aWWZLajUAXbLn8d4-evXGarDqbUQvUGQ9oqzEAEPRt0hL5oDPwDg";
train_getPath(request, path);
replay();
ComponentEventLinkEncoderImpl linkEncoder = new
ComponentEventLinkEncoderImpl(null, contextPathEncoder, null,
request, null, null, null, null, true, "", null, null);
ComponentEventRequestParameters parameters =
linkEncoder.decodeComponentEventRequest(request);
assertNull(parameters);
verify();
}
And it works, so I'm not hitting the same JVM bug as you guys, maybe because
I'm on a Mac.
was (Author: hlship):
Hm. I added a quick test for this:
{{{
/**
* And thanks to our friends at Lithium: TAP5-1791
*/
@Test
public void can_handle_extreme_regular_expression()
{
ComponentClassResolver resolver = mockComponentClassResolver();
Request request = mockRequest();
LocalizationSetter ls = mockLocalizationSetter();
MetaDataLocator metaDataLocator = neverWhitelistProtected();
train_getParameter(request, InternalConstants.PAGE_CONTEXT_NAME, null);
train_getParameter(request, InternalConstants.CONTAINER_PAGE_NAME,
null);
train_getLocale(request, Locale.ENGLISH);
ls.setNonPeristentLocaleFromLocaleName("en");
String path =
"/user/UserResetPasswordPage/user-id/22/reset-password-token/bHLQiMR3VD6eFTQ7Txj2y4u_HyGKiHwC9bF6dazuuf3__qhKpK3rtSbZHwB6W2dbmGCmPS1By1uq-rcZXO-Ooxd6Ire1vwPpxXUAlx3Mf15ShvJEf8r9MfWEMATS3Pyr-HaGiqqcjN2IhDtJtxnypanQkBrVPMC_APwDp7aWWZLajUAXbLn8d4-evXGarDqbUQvUGQ9oqzEAEPRt0hL5oDPwDg";
train_getPath(request, path);
train_setLocaleFromLocaleName(ls, "user", false);
train_isPageName(resolver, "user/UserResetPasswordPage", true);
train_canonicalizePageName(resolver, "user/UserResetPasswordPage",
"user/UserResetPasswordPage");
replay();
ComponentEventLinkEncoderImpl linkEncoder = new
ComponentEventLinkEncoderImpl(resolver, contextPathEncoder, ls,
request, null, null, null, null, true, "", metaDataLocator,
null);
ComponentEventRequestParameters parameters =
linkEncoder.decodeComponentEventRequest(request);
assertNull(parameters);
verify();
}
}}}
And it works, so I'm not hitting the same JVM bug as you guys, maybe because
I'm on a Mac.
> java.lang.StackOverflowError was thrown at
> org.apache.tapestry5.internal.services.ComponentEventLinkEncoderImpl.decodeComponentEventRequest(Request):243
> --------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: TAP5-1791
> URL: https://issues.apache.org/jira/browse/TAP5-1791
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3
> Reporter: Eddie Lo
> Assignee: Howard M. Lewis Ship
> Priority: Critical
> Attachments: LIA25066Test.java
>
>
> Some path parameters will cause tapestry to get into infinite loop.
> The exact problem is caused by the combination of 3 factors:
> * A low priority bug in JVM --
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6882582
> * A regex generated by Tapestry 3.0
> ^/(((\w(?:\w|-)*)/)*(\w+))(\.(\w+(\.\w+)*))?(\:(\w+))?(/(.*))?
> * A long and complex enough path parameter.
> /t5/user/UserResetPasswordPage/user-id/22/reset-password-token/bHLQiMR3VD6eFTQ7Txj2y4u_HyGKiHwC9bF6dazuuf3__qhKpK3rtSbZHwB6W2dbmGCmPS1By1uq-rcZXO-Ooxd6Ire1vwPpxXUAlx3Mf15ShvJEf8r9MfWEMATS3Pyr-HaGiqqcjN2IhDtJtxnypanQkBrVPMC_APwDp7aWWZLajUAXbLn8d4-evXGarDqbUQvUGQ9oqzEAEPRt0hL5oDPwDg
> When all the the 3 factors are hit, tapestry will get into an infinite loop
> at
> org.apache.tapestry5.internal.services.ComponentEventLinkEncoderImpl.decodeComponentEventRequest(Request):243
> and following exception is thrown
> [5DAC745F] java.lang.StackOverflowError
> at java.util.regex.Pattern$BranchConn.match(Pattern.java:4078)
> at java.util.regex.Pattern$BmpCharProperty.match(Pattern.java:3366)
> at java.util.regex.Pattern$Branch.match(Pattern.java:4114)
> at java.util.regex.Pattern$GroupHead.match(Pattern.java:4168)
> at java.util.regex.Pattern$Loop.match(Pattern.java:4295)
> at java.util.regex.Pattern$GroupTail.match(Pattern.java:4227)
> at java.util.regex.Pattern$BranchConn.match(Pattern.java:4078)
> at java.util.regex.Pattern$BmpCharProperty.match(Pattern.java:3366)
> at java.util.regex.Pattern$Branch.match(Pattern.java:4114)
> at java.util.regex.Pattern$GroupHead.match(Pattern.java:4168)
> at java.util.regex.Pattern$Loop.match(Pattern.java:4295)
> at java.util.regex.Pattern$GroupTail.match(Pattern.java:4227)
> at java.util.regex.Pattern$BranchConn.match(Pattern.java:4078)
> at java.util.regex.Pattern$BmpCharProperty.match(Pattern.java:3366)
> ...
> There is a limit in java only holding the top 1024 stacks. As the frame is
> small this time, it have far more that 1024, the bottom is truncated and lost.
> However, I used a debugger to confirm that it is thrown from
> org.apache.tapestry5.internal.services.ComponentEventLinkEncoderImpl.decodeComponentEventRequest(Request):243
> While the problem is caused by JVM bug (Oracle) and a long complex path
> parameters (us), it is recommended to also fix this in Tapestry to use a
> simpler regex.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
