[ 
https://issues.apache.org/jira/browse/TAP5-2293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14113509#comment-14113509
 ] 

Lance commented on TAP5-2293:
-----------------------------

I've noticed that the fix uses utf-8 encoding.
{code}
private final static String OUTPUT_CHARSET = "utf-8";
{code}

Should this use the "tapestry.charset" symbol instead?

SymbolConstants.java
{code}

 /**
     * The  charset used when rendering page markup; the charset is also used 
as ther request encoding when handling
     * incoming requests. The default is "UTF-8".
     */
    public static final String CHARSET = "tapestry.charset";
{code}

> Closure minimizer produces invalid output on non-UTF-8 systems
> --------------------------------------------------------------
>
>                 Key: TAP5-2293
>                 URL: https://issues.apache.org/jira/browse/TAP5-2293
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-webresources
>    Affects Versions: 5.4
>            Reporter: Jochen Kemnade
>            Assignee: Jochen Kemnade
>            Priority: Blocker
>              Labels: patch
>             Fix For: 5.4
>
>         Attachments: 
> 0001-specify-encoding-when-getting-an-InputStream-from-a-.patch
>
>
> When reading the minimization result from the Closure Compiler, the String is 
> turned into an input stream using the platform's default encoding. If that is 
> not UTF-8, the content that is sent to the browser is probably broken.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to