[ https://issues.apache.org/jira/browse/TAP5-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14329077#comment-14329077 ]
Jochen Kemnade edited comment on TAP5-2337 at 2/20/15 3:52 PM: --------------------------------------------------------------- Alright, I tried to combine the ideas of all three of us and here's what I've come up with. The patch is not ready to be committed, lacks some comments and JavaDoc, and I haven't made any benchmarks yet, but that's the basic idea. Thoughts? was (Author: jkemnade): Alright, I tried to combine the ideas of all three of us and here's what I've come up with. The patch is not ready, lacks some comments and JavaDoc, but that's the basic idea. Thoughts? > Reduce number of calls of AbstractStringBuilder.expandCapacity > -------------------------------------------------------------- > > Key: TAP5-2337 > URL: https://issues.apache.org/jira/browse/TAP5-2337 > Project: Tapestry 5 > Issue Type: Improvement > Reporter: Michael Mikhulya > Priority: Minor > Labels: performance > Attachments: > 0001-TAP5-2337-Reduce-number-of-calls-of-AbstractStringBu-jk.patch, > 0001-TAP5-2337-Reduce-number-of-calls-of-AbstractStringBu.patch, > Tapestry-StringBuilder.png > > > During profiling of Tapestry framework I found that > AbstractStringBuilder.expandCapacity is called very frequently. > There is a patch that get rid of creation StringBuilder with following calls > of expandCapacity (which allocate memory and copy current content into it). > I have to thank Dmitriy Ilyin, who helped me to investigate the issue and to > find the simplest solution (actually we get a little bit less code while > improving performance). > With this improvement time per request decreased on 0.5ms (1% of overall > time)on our test. All measurements were done with apache benchmark after warm > up phase. -- This message was sent by Atlassian JIRA (v6.3.4#6332)