[ 
https://issues.apache.org/jira/browse/TAP5-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14335031#comment-14335031
 ] 

Jochen Kemnade commented on TAP5-2337:
--------------------------------------

I know what you mean but I wanted to try to accomplish the improvements without 
changing the {{MarkupModel}} interface. Oh how I long for Java 8 default 
methods. This will make adding new methods so much easier. 
I haven't gotten around to making any measurements, those things take pretty 
long to set up properly and I'm trying to concentrate more on bug-type issues, 
however tempting those performance improvements may be.

> Reduce number of calls of AbstractStringBuilder.expandCapacity
> --------------------------------------------------------------
>
>                 Key: TAP5-2337
>                 URL: https://issues.apache.org/jira/browse/TAP5-2337
>             Project: Tapestry 5
>          Issue Type: Improvement
>            Reporter: Michael Mikhulya
>            Priority: Minor
>              Labels: performance
>         Attachments: 
> 0001-TAP5-2337-Reduce-number-of-calls-of-AbstractStringBu-jk.patch, 
> 0001-TAP5-2337-Reduce-number-of-calls-of-AbstractStringBu.patch, 
> Tapestry-StringBuilder.png
>
>
> During profiling of Tapestry framework I found that 
> AbstractStringBuilder.expandCapacity is called very frequently.
> There is a patch that get rid of creation StringBuilder with following calls 
> of expandCapacity (which allocate memory and copy current content into it).
> I have to thank Dmitriy Ilyin, who helped me to investigate the issue and to 
> find the simplest solution (actually we get a little bit less code while 
> improving performance).
> With this improvement time per request decreased on 0.5ms (1% of overall 
> time)on our test. All measurements were done with apache benchmark after warm 
> up phase.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to