[ 
https://issues.apache.org/jira/browse/TAP5-2588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16194661#comment-16194661
 ] 

Hudson commented on TAP5-2588:
------------------------------

FAILURE: Integrated in Jenkins build tapestry-trunk-freestyle #1634 (See 
[https://builds.apache.org/job/tapestry-trunk-freestyle/1634/])
TAP5-2588: upgrade ASM to 6.0 (jkemnade: rev 
74324b3130c9f74c1684a08171b7a2ca56532fe1)
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/InvokeDynamicInsnNode.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/xml/SAXAnnotationAdapter.java
* (delete) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/optimizer/JarOptimizer.java
* (delete) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/optimizer/shrink-annotations.properties
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/util/TraceAnnotationVisitor.java
* (delete) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/optimizer/MethodOptimizer.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/MethodVisitor.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/commons/RemappingClassAdapter.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/commons/JSRInlinerAdapter.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/ClassVisitor.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/ClassNode.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/FieldInsnNode.java
* (add) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/commons/AnnotationRemapper.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/commons/RemappingMethodAdapter.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/AnnotationNode.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/signature/SignatureWriter.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/util/CheckMethodAdapter.java
* (edit) 
plastic/src/main/java/org/apache/tapestry5/internal/plastic/AbstractAnnotationBuilder.java
* (add) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/commons/SignatureRemapper.java
* (add) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/ModuleNode.java
* (add) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/ModuleRequireNode.java
* (add) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/commons/ClassRemapper.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/xml/SAXCodeAdapter.java
* (delete) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/optimizer/ClassConstantsCollector.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/util/CheckSignatureAdapter.java
* (add) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/ModuleProvideNode.java
* (add) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/commons/ModuleResolutionAttribute.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/xml/asm-xml.dtd
* (add) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/ModuleVisitor.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/util/CheckAnnotationAdapter.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/Frame.java
* (delete) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/optimizer/shrink-resize.properties
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/analysis/BasicVerifier.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/signature/SignatureReader.java
* (delete) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/optimizer/shrink.properties
* (add) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/commons/ModuleTargetAttribute.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/FieldNode.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/Opcodes.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/commons/Remapper.java
* (add) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/commons/FieldRemapper.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/MethodWriter.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/ParameterNode.java
* (add) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/util/TraceModuleVisitor.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/commons/AnalyzerAdapter.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/Item.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/MultiANewArrayInsnNode.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/analysis/BasicInterpreter.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/LocalVariableAnnotationNode.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/FieldVisitor.java
* (add) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/ModuleWriter.java
* (delete) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/optimizer/MethodConstantsCollector.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/commons/TryCatchBlockSorter.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/util/ASMifiable.java
* (delete) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/optimizer/NameMapping.java
* (add) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/ModuleOpenNode.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/FieldWriter.java
* (add) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/commons/ModuleHashesAttribute.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/util/TraceSignatureVisitor.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/xml/Processor.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/commons/CodeSizeEvaluator.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/signature/SignatureVisitor.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/commons/RemappingAnnotationAdapter.java
* (delete) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/optimizer/jdk1.3.1_19.txt.gz
* (delete) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/optimizer/Constant.java
* (delete) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/optimizer/shrink-writer.properties
* (delete) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/optimizer/shrink-frames.properties
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/xml/SAXClassAdapter.java
* (add) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/commons/MethodRemapper.java
* (delete) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/optimizer/Shrinker.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/MethodInsnNode.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/Type.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/commons/GeneratorAdapter.java
* (delete) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/optimizer/AnnotationConstantsCollector.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/util/ASMifier.java
* (add) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/CurrentFrame.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/analysis/SimpleVerifier.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/commons/LocalVariablesSorter.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/AnnotationWriter.java
* (delete) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/optimizer/shrink-signatures.properties
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/TryCatchBlockNode.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/TypeAnnotationNode.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/TypeInsnNode.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/commons/StaticInitMerger.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/util/Textifiable.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/commons/InstructionAdapter.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/xml/SAXFieldAdapter.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/InnerClassNode.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/util/Printer.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/util/TraceMethodVisitor.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/util/TraceFieldVisitor.java
* (delete) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/optimizer/ConstantPool.java
* (delete) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/optimizer/jdk1.2.2_017.txt.gz
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/AnnotationVisitor.java
* (delete) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/optimizer/ClassOptimizer.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/commons/RemappingSignatureAdapter.java
* (add) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/xml/SAXModuleAdapter.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/ClassReader.java
* (add) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/util/CheckModuleAdapter.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/util/CheckClassAdapter.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/util/CheckFieldAdapter.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/ClassWriter.java
* (delete) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/optimizer/FieldConstantsCollector.java
* (add) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/commons/ModuleRemapper.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/Handle.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/commons/AdviceAdapter.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/util/Textifier.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/analysis/SourceInterpreter.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/commons/SerialVersionUIDAdder.java
* (add) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/ModuleExportNode.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/util/TraceClassVisitor.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/InsnList.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/AbstractInsnNode.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/MethodNode.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/commons/RemappingFieldAdapter.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/LdcInsnNode.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/xml/ASMContentHandler.java
* (edit) 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/Label.java


> Does not work with Java 9
> -------------------------
>
>                 Key: TAP5-2588
>                 URL: https://issues.apache.org/jira/browse/TAP5-2588
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: plastic
>    Affects Versions: 5.4.3
>            Reporter: Jochen Kemnade
>            Priority: Critical
>
> You cannot use Tapestry with Java 9 because of an outdated ASM version in 
> plastic (5.0.4). AFAICT, we'll need to upgrade to 6.0. My attempt do do so 
> results in a {{ClassCastException}} in 
> {{org.apache.tapestry5.plastic.ArrayAttributeAnnotations.explicit values for 
> array attributes}}.
> {noformat}
> java.lang.ClassCastException: [I cannot be cast to 
> java.base/[Ljava.lang.Object;
>       at 
> org.apache.tapestry5.internal.plastic.AbstractAnnotationBuilder$2.visitEnd(AbstractAnnotationBuilder.java:134)
>       at 
> org.apache.tapestry5.internal.plastic.asm.tree.AnnotationNode.accept(AnnotationNode.java:284)
>       at 
> org.apache.tapestry5.internal.plastic.asm.tree.AnnotationNode.accept(AnnotationNode.java:251)
>       at 
> org.apache.tapestry5.internal.plastic.PlasticClassPool.createAnnotation(PlasticClassPool.java:307)
>       at 
> org.apache.tapestry5.internal.plastic.PlasticClassPool$4.buildAnnotation(PlasticClassPool.java:286)
>       at 
> org.apache.tapestry5.internal.plastic.PlasticClassPool$4.getAnnotation(PlasticClassPool.java:270)
>       at 
> org.apache.tapestry5.internal.plastic.DelegatingAnnotationAccess.getAnnotation(DelegatingAnnotationAccess.java:42)
>       at 
> org.apache.tapestry5.internal.plastic.PlasticClassImpl.getAnnotation(PlasticClassImpl.java:342)
>       at org.apache.tapestry5.plastic.ArrayAttributeAnnotations.explicit 
> values for array attributes(ArrayAttributeAnnotations.groovy:27)
> {noformat}
> The {{AbstractAnnotationBuilder}} subclass tries to cast an {{int[]}} to an 
> {{Object[]}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to