[ 
https://issues.apache.org/jira/browse/TAP5-2075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16730985#comment-16730985
 ] 

Balázs Palcsó edited comment on TAP5-2075 at 1/1/19 7:54 PM:
-------------------------------------------------------------

I have attached a new patch that I build on top of [~fscheffer]'s patch which 
adds client side validation and integration tests:
 # [^0001-TAP5-2075-Checkbox-doesn-t-trigger-VALIDATE-event.patch]
 # [^0002-TAP5-2075-Checkbox-Checked-and-Unchecked-validator-w.patch]
 # [^0003-TAP5-2075-AssertTrue-and-AssertFalse-client-side-Bea.patch]
 # [^0004-TAP5-2075-Fix-checkbox-validation-error-message-layo.patch]
 # [^0005-TAP5-2075-Release-notes-for-checkbox-validators.patch]

Could somebody please review and commit them?


was (Author: balapal):
I have attached a new patch that I build on top of [~fscheffer]'s patch which 
adds client side validation and integration tests:
 # [^0001-TAP5-2075-Checkbox-doesn-t-trigger-VALIDATE-event.patch]
 # [^0002-TAP5-2075-Checkbox-Checked-and-Unchecked-validator-w.patch]
 # [^0003-TAP5-2075-AssertTrue-and-AssertFalse-client-side-Bea.patch]
 # [^0004-TAP5-2075-Fix-checkbox-validation-error-message-layo.patch]

Could somebody please review and commit them?

> Checkbox doesn't trigger VALIDATE event
> ---------------------------------------
>
>                 Key: TAP5-2075
>                 URL: https://issues.apache.org/jira/browse/TAP5-2075
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3.6, 5.4
>            Reporter: Geoff Callender
>            Assignee: Thiago H. de Paula Figueiredo
>            Priority: Major
>              Labels: patch
>         Attachments: 
> 0001-TAP5-2075-Checkbox-doesn-t-trigger-VALIDATE-event.patch, 
> 0002-TAP5-2075-Checkbox-Checked-and-Unchecked-validator-w.patch, 
> 0003-TAP5-2075-AssertTrue-and-AssertFalse-client-side-Bea.patch, 
> 0004-TAP5-2075-Fix-checkbox-validation-error-message-layo.patch, 
> 0005-TAP5-2075-Release-notes-for-checkbox-validators.patch, 
> 0006-TAP5-2075-Checkbox-doesn-t-trigger-VALIDATE-event.patch, asserttrue.js
>
>
> Imagine a list of entries with a "delete" checkbox on each row.
> When submitted, I would like to validate each checked row to decide whether 
> it is OK to delete.
> I can write an event handler, onValidateFromDelete(), but it will never be 
> called because Checkbox doesn't bubble up the VALIDATE event.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to