[ 
https://issues.apache.org/jira/browse/TAP5-2668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354597#comment-17354597
 ] 

Hudson commented on TAP5-2668:
------------------------------

FAILURE: Integrated in Jenkins build Tapestry » tapestry-trunk-freestyle #87 
(See 
[https://ci-builds.apache.org/job/Tapestry/job/tapestry-trunk-freestyle/87/])
TAP5-2668: Move spock-tapestry extension to tapestry-test (thiago: rev 
f9576b8a5a548ed3edd547d1b495f6d2a68195cb)
* (add) tapestry-spock/src/test/java/org/apache/tapestry5/spock/Service2.java
* (add) 
tapestry-spock/src/test/groovy/org/apache/tapestry5/spock/TapestrySpecInheritance.groovy
* (add) tapestry-spock/src/test/java/org/apache/tapestry5/spock/Service1.java
* (add) tapestry-spock/build.gradle
* (add) tapestry-spock/src/test/java/org/apache/tapestry5/spock/Module2.java
* (edit) settings.gradle
* (add) 
tapestry-spock/src/test/groovy/org/apache/tapestry5/spock/InjectionExamples.groovy
* (add) 
tapestry-spock/src/test/java/org/apache/tapestry5/spock/Service2Impl.java
* (add) 
tapestry-spock/src/main/java/org/apache/tapestry5/spock/TapestrySpockExtension.java
* (add) 
tapestry-spock/src/main/resources/META-INF/services/org.spockframework.runtime.extension.IGlobalExtension
* (add) tapestry-spock/src/test/java/org/apache/tapestry5/spock/Module1.java
* (add) 
tapestry-spock/src/main/java/org/apache/tapestry5/spock/SpockTapestry.java
* (add) 
tapestry-spock/src/main/java/org/apache/tapestry5/spock/TapestryInterceptor.java
* (add) tapestry-spock/src/test/java/org/apache/tapestry5/spock/Service3.java
* (add) 
tapestry-spock/src/test/java/org/apache/tapestry5/spock/Service1Impl.java
* (add) tapestry-spock/README.md
* (add) 
tapestry-spock/src/main/java/org/apache/tapestry5/spock/ExtensionModule.java
* (add) 
tapestry-spock/src/test/groovy/org/apache/tapestry5/spock/InjectionExamplesWithImportModule.groovy
* (add) 
tapestry-spock/src/test/java/org/apache/tapestry5/spock/Service3Impl.java
* (add) 
tapestry-spock/src/test/groovy/org/apache/tapestry5/spock/BeforeRegistryCreatedMethod.groovy


> Move spock-tapestry extension to tapestry-test
> ----------------------------------------------
>
>                 Key: TAP5-2668
>                 URL: https://issues.apache.org/jira/browse/TAP5-2668
>             Project: Tapestry 5
>          Issue Type: Wish
>          Components: tapestry-test
>            Reporter: Leonard Brünings
>            Assignee: Thiago Henrique De Paula Figueiredo
>            Priority: Major
>             Fix For: 5.7.3
>
>         Attachments: TAP5-2668.patch
>
>
> Hi I'm the maintainer of the Spock Framework and I'd like to propose, that 
> the spock-tapestry extensions is migrated to tapestry-test or tapestry-spock. 
> The current implementation supports only 5.4.3 and a check with 5.7.1 
> revealed some removed classes that would require another layer of reflection 
> indirection to support different versions.
> In my opinion it would make more sense to move the extension to Tapestry, as 
> this would simplify the code quite a bit.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to