[
https://issues.apache.org/jira/browse/TAP5-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715593#comment-17715593
]
Ben Weidig commented on TAP5-2730:
----------------------------------
Just wanted to give my two cents, too.
IMO such a change is acceptable, as only a few, or any, people might have
needed a custom compressed ModuleDispatcher.
And those who did, had to be aware of the typo in the id and the possible
implications in future updates.
Any issues after a version update should lead the devs to check the release
notes, and if it's mentioned as a "breaking change", it will be fixed
immediately on their end.
However, this leads to another thing I want to mention but doesn't need to be
discussed in this ticket: constants for service ids.
All services should use constants for their ids and the order constraints, too,
so a change like the one in this ticket won't have any significant
ramifications.
I have "looking at OrderedConfiguration" due to how constraints are generally
handled on my to-do list, so I might think about improving them anyway.
> Misspelt ‘ComnpressedModules’ object id
> ---------------------------------------
>
> Key: TAP5-2730
> URL: https://issues.apache.org/jira/browse/TAP5-2730
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-core
> Reporter: Volker Lamp
> Priority: Trivial
>
> in JavaScriptModule.java:289
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
