Ben Weidig created TAP5-2822:
--------------------------------
Summary: EsModuleManager includes TypeScript type definition files
in base modules
Key: TAP5-2822
URL: https://issues.apache.org/jira/browse/TAP5-2822
Project: Tapestry 5
Issue Type: Improvement
Components: tapestry-core
Affects Versions: 5.10.0
Reporter: Ben Weidig
The {{EsModuleManager}} determines which files to include in the base modules
based on the {{endsWith}} matching of the file path.
({{{}EsModuleManagerImpl.java:163{}}})
However, the matching is done on the extension without a dot, which are stored
in the {{extensions}} field.
This is too lenient, as {{d.ts}} would be included, as are files ending with
the extension, even though it’s not an extension.
Proposed fixes:
* Match on the correct extension, including the dot. It seems the field is
used only for that, so adding the dotted extensions instead of the bare ones
would help.
* Don’t include the type definition fields in the Classpath. They belong in
the NPM package. This way, we don’t need an additional check to exclude
{{.d.ts}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
