This is an automated email from the ASF dual-hosted git repository. benweidig pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tapestry-5.git
commit 1b017fb269065239560ce61276c39e4f9d2f1681 Author: Ben Weidig <[email protected]> AuthorDate: Sat Apr 18 11:27:30 2026 +0200 GoogleClosureMinimizer: further optimizations Trying to find the best option set to not let it interfere too much, as we only use it for whitespace removal. --- .../internal/webresources/GoogleClosureMinimizer.java | 2 +- .../GoogleClosureMinimizerOptionsProviderImpl.java | 17 ++++++++++++----- 2 files changed, 13 insertions(+), 6 deletions(-) diff --git a/tapestry-webresources/src/main/java/org/apache/tapestry5/internal/webresources/GoogleClosureMinimizer.java b/tapestry-webresources/src/main/java/org/apache/tapestry5/internal/webresources/GoogleClosureMinimizer.java index 3a7835129..3db20fe17 100644 --- a/tapestry-webresources/src/main/java/org/apache/tapestry5/internal/webresources/GoogleClosureMinimizer.java +++ b/tapestry-webresources/src/main/java/org/apache/tapestry5/internal/webresources/GoogleClosureMinimizer.java @@ -50,7 +50,7 @@ public class GoogleClosureMinimizer extends AbstractMinimizer static { - Compiler.setLoggingLevel(Level.SEVERE); + Compiler.setLoggingLevel(Level.OFF); } public GoogleClosureMinimizer(Logger logger, diff --git a/tapestry-webresources/src/main/java/org/apache/tapestry5/internal/webresources/GoogleClosureMinimizerOptionsProviderImpl.java b/tapestry-webresources/src/main/java/org/apache/tapestry5/internal/webresources/GoogleClosureMinimizerOptionsProviderImpl.java index e59f53a88..1bdaeddc6 100644 --- a/tapestry-webresources/src/main/java/org/apache/tapestry5/internal/webresources/GoogleClosureMinimizerOptionsProviderImpl.java +++ b/tapestry-webresources/src/main/java/org/apache/tapestry5/internal/webresources/GoogleClosureMinimizerOptionsProviderImpl.java @@ -1,3 +1,15 @@ +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + package org.apache.tapestry5.internal.webresources; import java.util.Optional; @@ -9,10 +21,8 @@ import org.apache.tapestry5.webresources.WebResourcesSymbols; import com.google.javascript.jscomp.BlackHoleErrorManager; import com.google.javascript.jscomp.CheckLevel; -import com.google.javascript.jscomp.ClosureCodingConvention; import com.google.javascript.jscomp.CompilationLevel; import com.google.javascript.jscomp.CompilerOptions; -import com.google.javascript.jscomp.DependencyOptions; import com.google.javascript.jscomp.DiagnosticGroup; import com.google.javascript.jscomp.DiagnosticGroups; import com.google.javascript.jscomp.deps.ModuleLoader; @@ -39,9 +49,6 @@ public class GoogleClosureMinimizerOptionsProviderImpl implements GoogleClosureM options.setWarningLevel(DiagnosticGroup.forType(ModuleLoader.INVALID_MODULE_PATH), CheckLevel.OFF); options.setWarningLevel(DiagnosticGroups.NON_STANDARD_JSDOC, CheckLevel.OFF); options.setWarningLevel(DiagnosticGroups.PARSING, CheckLevel.OFF); - options.setModuleResolutionMode(ModuleLoader.ResolutionMode.BROWSER); - options.setDependencyOptions(DependencyOptions.none()); - options.setCodingConvention(new ClosureCodingConvention()); options.setErrorHandler(new BlackHoleErrorManager()); return Optional.of(options);
