[ 
https://issues.apache.org/jira/browse/TAP5-2826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18074769#comment-18074769
 ] 

ASF subversion and git services commented on TAP5-2826:
-------------------------------------------------------

Commit 0dbc5bd3da5e62d54667b534542a5c36b158de1e in tapestry-5's branch 
refs/heads/master from Ben Weidig
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=0dbc5bd3d ]

TAP5-2826: allow null value for render variables


> Render variable check should allow null values
> ----------------------------------------------
>
>                 Key: TAP5-2826
>                 URL: https://issues.apache.org/jira/browse/TAP5-2826
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: tapestry-core
>    Affects Versions: 5.9.1, 5.10.0
>            Reporter: Ben Weidig
>            Assignee: Ben Weidig
>            Priority: Minor
>
> h2. Expected Behavior
> Render variables (e.g., informal parameters on a block/delegate combo should 
> be available even if the value is {{null}}
> h2. Actual behaviour
> {{org.apache.tapestry5.internal.structure.InternalComponentResourcesImpl.getRenderVariable(String)}}
>  throws an {{IllegalArgumentExpception}} if the value is {{{}null{}}}, saying 
> the render variable is missing.
> However, there’s no distinction between “key was found but {{{}value == 
> null{}}}” and an actual missing render variable.
> h2. Suggested Change
> Only throw an {{IllegalArgumentException}} if the key is actually missing, 
> not on null values.
> AFAICT from a quick glance, the underlying custom Map implementation 
> ({{{}org.apache.tapestry5.commons.util.CaseInsensitiveMap<V>{}}}) should 
> support {{null}} values, but I need to check.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to