remove unused variables and statements
Project: http://git-wip-us.apache.org/repos/asf/incubator-taverna-mobile/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-taverna-mobile/commit/6579ecbf Tree: http://git-wip-us.apache.org/repos/asf/incubator-taverna-mobile/tree/6579ecbf Diff: http://git-wip-us.apache.org/repos/asf/incubator-taverna-mobile/diff/6579ecbf Branch: refs/heads/master Commit: 6579ecbf338daedca5e9b405098993dd21d3e055 Parents: b29f94e Author: Sagar <[email protected]> Authored: Mon Jul 25 21:19:08 2016 +0530 Committer: Sagar <[email protected]> Committed: Mon Jul 25 21:19:08 2016 +0530 ---------------------------------------------------------------------- .../mobile/ui/imagezoom/ImageZoomFragment.java | 7 +------ .../mobile/ui/imagezoom/ImageZoomPresenter.java | 14 +++----------- 2 files changed, 4 insertions(+), 17 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-taverna-mobile/blob/6579ecbf/app/src/main/java/org/apache/taverna/mobile/ui/imagezoom/ImageZoomFragment.java ---------------------------------------------------------------------- diff --git a/app/src/main/java/org/apache/taverna/mobile/ui/imagezoom/ImageZoomFragment.java b/app/src/main/java/org/apache/taverna/mobile/ui/imagezoom/ImageZoomFragment.java index f73a836..3cb8efc 100644 --- a/app/src/main/java/org/apache/taverna/mobile/ui/imagezoom/ImageZoomFragment.java +++ b/app/src/main/java/org/apache/taverna/mobile/ui/imagezoom/ImageZoomFragment.java @@ -40,7 +40,6 @@ import com.bumptech.glide.request.target.SizeReadyCallback; import com.bumptech.glide.request.target.Target; import org.apache.taverna.mobile.R; -import org.apache.taverna.mobile.data.DataManager; import org.apache.taverna.mobile.utils.ConnectionInfo; import butterknife.BindView; @@ -56,7 +55,6 @@ public class ImageZoomFragment extends Fragment implements ImageZoomMvpView { private static final String SERVER_ERROR = "Sever Error. Please try after sometime"; - private static final String TAG = "ImageZoomFragment"; @BindView(R.id.ivWorkflowImage) ImageView workflowImage; @@ -70,8 +68,6 @@ public class ImageZoomFragment extends Fragment implements ImageZoomMvpView { private String jpgURI; - private DataManager dataManager; - private ImageZoomPresenter mImageZoomPresenter; private ConnectionInfo mConnectionInfo; @@ -98,8 +94,7 @@ public class ImageZoomFragment extends Fragment implements ImageZoomMvpView { jpgURI = getArguments().getString(JPG_URI); - dataManager = new DataManager(); - mImageZoomPresenter = new ImageZoomPresenter(dataManager); + mImageZoomPresenter = new ImageZoomPresenter(); mConnectionInfo = new ConnectionInfo(getContext()); } http://git-wip-us.apache.org/repos/asf/incubator-taverna-mobile/blob/6579ecbf/app/src/main/java/org/apache/taverna/mobile/ui/imagezoom/ImageZoomPresenter.java ---------------------------------------------------------------------- diff --git a/app/src/main/java/org/apache/taverna/mobile/ui/imagezoom/ImageZoomPresenter.java b/app/src/main/java/org/apache/taverna/mobile/ui/imagezoom/ImageZoomPresenter.java index 1d5ca90..fd8d43d 100644 --- a/app/src/main/java/org/apache/taverna/mobile/ui/imagezoom/ImageZoomPresenter.java +++ b/app/src/main/java/org/apache/taverna/mobile/ui/imagezoom/ImageZoomPresenter.java @@ -37,26 +37,18 @@ import com.bumptech.glide.request.target.Target; import com.caverock.androidsvg.SVG; import org.apache.taverna.mobile.R; -import org.apache.taverna.mobile.data.DataManager; import org.apache.taverna.mobile.ui.base.BasePresenter; import org.apache.taverna.mobile.utils.SvgDecoder; import org.apache.taverna.mobile.utils.SvgDrawableTranscoder; import java.io.InputStream; -import rx.Subscription; - public class ImageZoomPresenter extends BasePresenter<ImageZoomMvpView> { - public static final String NO_IMAGE_URI = "NO Image Found"; - public static final String DB_ERROR = "There is some problem. Please try after sometime "; - private DataManager mDataManager; - private Subscription mSubscriptions; - private GenericRequestBuilder<Uri, InputStream, SVG, PictureDrawable> requestBuilder; - public ImageZoomPresenter(DataManager dataManager) { + private GenericRequestBuilder<Uri, InputStream, SVG, PictureDrawable> requestBuilder; - mDataManager = dataManager; + public ImageZoomPresenter() { } @@ -84,7 +76,7 @@ public class ImageZoomPresenter extends BasePresenter<ImageZoomMvpView> { @Override public void detachView() { super.detachView(); - if (mSubscriptions != null) mSubscriptions.unsubscribe(); + } public void loadImage(String svgURI, final ImageView imageView) {
