contextual view code review
Project: http://git-wip-us.apache.org/repos/asf/incubator-taverna-common-activities/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-taverna-common-activities/commit/dbadfb2d Tree: http://git-wip-us.apache.org/repos/asf/incubator-taverna-common-activities/tree/dbadfb2d Diff: http://git-wip-us.apache.org/repos/asf/incubator-taverna-common-activities/diff/dbadfb2d Branch: refs/heads/cwl-browse Commit: dbadfb2d0316fea6eb7fe4e3f032fa2a38c294cf Parents: 37d2833 Author: ThilinaManamgoda <[email protected]> Authored: Fri Jul 29 01:52:33 2016 +0530 Committer: ThilinaManamgoda <[email protected]> Committed: Fri Jul 29 01:52:33 2016 +0530 ---------------------------------------------------------------------- .../taverna/cwl/ui/serviceprovider/CwlServiceProvider.java | 3 +-- .../java/org/apache/taverna/cwl/ui/view/CwlContextualView.java | 4 ++-- .../java/org/apache/taverna/cwl/utilities/CwlContextualUtil.java | 4 +--- 3 files changed, 4 insertions(+), 7 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-taverna-common-activities/blob/dbadfb2d/taverna-cwl-activity-ui/src/main/java/org/apache/taverna/cwl/ui/serviceprovider/CwlServiceProvider.java ---------------------------------------------------------------------- diff --git a/taverna-cwl-activity-ui/src/main/java/org/apache/taverna/cwl/ui/serviceprovider/CwlServiceProvider.java b/taverna-cwl-activity-ui/src/main/java/org/apache/taverna/cwl/ui/serviceprovider/CwlServiceProvider.java index 6a54805..64b2f11 100644 --- a/taverna-cwl-activity-ui/src/main/java/org/apache/taverna/cwl/ui/serviceprovider/CwlServiceProvider.java +++ b/taverna-cwl-activity-ui/src/main/java/org/apache/taverna/cwl/ui/serviceprovider/CwlServiceProvider.java @@ -25,7 +25,6 @@ import java.nio.file.Path; import java.nio.file.Paths; import java.util.ArrayList; import java.util.Arrays; -import java.util.Iterator; import java.util.List; import java.util.Map; import java.util.stream.Stream; @@ -111,7 +110,7 @@ public class CwlServiceProvider extends AbstractConfigurableServiceProvider impl } /** * This method checks whether provided path is valid or not and if it's valid the it's added to the list - * @param defaultPaths arrylist to hold valid paths + * @param defaultPaths List to hold valid paths * @param path * @param path1 if there is no second path argument this should be set to null */ http://git-wip-us.apache.org/repos/asf/incubator-taverna-common-activities/blob/dbadfb2d/taverna-cwl-activity-ui/src/main/java/org/apache/taverna/cwl/ui/view/CwlContextualView.java ---------------------------------------------------------------------- diff --git a/taverna-cwl-activity-ui/src/main/java/org/apache/taverna/cwl/ui/view/CwlContextualView.java b/taverna-cwl-activity-ui/src/main/java/org/apache/taverna/cwl/ui/view/CwlContextualView.java index 6e4e71c..e57d1aa 100644 --- a/taverna-cwl-activity-ui/src/main/java/org/apache/taverna/cwl/ui/view/CwlContextualView.java +++ b/taverna-cwl-activity-ui/src/main/java/org/apache/taverna/cwl/ui/view/CwlContextualView.java @@ -121,10 +121,10 @@ public class CwlContextualView extends HTMLBasedActivityContextualView { String summary = "<table border=\"" + TABLE_BORDER + "\" style=\"width:" + TABLE_WIDTH + "\" cellpadding=\"" + TABLE_CELL_PADDING + "\" >"; - String description = ""; + // Get the CWL tool Description if (cwlToolConfiguration.has(DESCRIPTION)) { - description = cwlToolConfiguration.get(DESCRIPTION).asText(); + String description = cwlToolConfiguration.get(DESCRIPTION).asText(); summary = cwlutil.paragraphToHtml(summary, description); } http://git-wip-us.apache.org/repos/asf/incubator-taverna-common-activities/blob/dbadfb2d/taverna-cwl-utilities/src/main/java/org/apache/taverna/cwl/utilities/CwlContextualUtil.java ---------------------------------------------------------------------- diff --git a/taverna-cwl-utilities/src/main/java/org/apache/taverna/cwl/utilities/CwlContextualUtil.java b/taverna-cwl-utilities/src/main/java/org/apache/taverna/cwl/utilities/CwlContextualUtil.java index 2318669..f37a862 100644 --- a/taverna-cwl-utilities/src/main/java/org/apache/taverna/cwl/utilities/CwlContextualUtil.java +++ b/taverna-cwl-utilities/src/main/java/org/apache/taverna/cwl/utilities/CwlContextualUtil.java @@ -22,9 +22,7 @@ import java.util.Map; import com.fasterxml.jackson.databind.JsonNode; public class CwlContextualUtil extends CWLUtil { - private static final int MAX_LINE_LENG = 80; - private static final String LINE_BREAK = "\n"; - private static final String SPACE = " "; + public CwlContextualUtil(JsonNode cwlFile) { super(cwlFile);
