This is an automated email from the ASF dual-hosted git repository.

linxinyuan pushed a commit to branch xinyuan-source-port
in repository https://gitbox.apache.org/repos/asf/texera.git


The following commit(s) were added to refs/heads/xinyuan-source-port by this 
push:
     new d0b40bdf6c update
d0b40bdf6c is described below

commit d0b40bdf6c8133cca470172275eeda8cddcfb676
Author: Xinyuan Lin <[email protected]>
AuthorDate: Fri Apr 10 15:30:33 2026 -0700

    update
---
 .../dataset-version-selector.component.ts          | 42 +++++++++-------------
 1 file changed, 16 insertions(+), 26 deletions(-)

diff --git 
a/frontend/src/app/workspace/component/dataset-version-selector/dataset-version-selector.component.ts
 
b/frontend/src/app/workspace/component/dataset-version-selector/dataset-version-selector.component.ts
index ca185a4cf1..eb2b2b4338 100644
--- 
a/frontend/src/app/workspace/component/dataset-version-selector/dataset-version-selector.component.ts
+++ 
b/frontend/src/app/workspace/component/dataset-version-selector/dataset-version-selector.component.ts
@@ -57,37 +57,27 @@ export class DatasetVersionSelectorComponent extends 
FieldType<FieldTypeConfig>
     }
 
   onDatasetChange(): void {
-    if (this.selectedDataset?.dataset.did !== undefined) {
-      this.loadVersions(this.selectedDataset.dataset.did);
+    if (this.selectedDataset) {
+      this.datasetService
+        .retrieveDatasetVersionList(this.selectedDataset.dataset.did!)
+        .pipe(untilDestroyed(this))
+        .subscribe(versions => {
+          this.datasetVersions = versions;
+          this.selectedVersion = versions[0];
+          this.onVersionChange();
+          this.changeDetectorRef.detectChanges();
+        });
+    } else {
+      this.selectedVersion = undefined;
+      this.onVersionChange();
     }
   }
 
   onVersionChange(): void {
-    if (!this.selectedDataset || !this.selectedVersion) {
-      this.formControl.setValue(null);
-      return;
-    }
-
     this.formControl.setValue(
-      
`/${this.selectedDataset.ownerEmail}/${this.selectedDataset.dataset.name}/${this.selectedVersion.name}`
+      this.selectedDataset && this.selectedVersion
+        ? 
`/${this.selectedDataset?.ownerEmail}/${this.selectedDataset?.dataset?.name}/${this.selectedVersion?.name}`
+        : null
     );
   }
-
-  private loadVersions(did: number, versionNameToSelect?: string): void {
-    this.datasetService
-      .retrieveDatasetVersionList(did)
-      .pipe(untilDestroyed(this))
-      .subscribe(versions => {
-        this.datasetVersions = versions;
-        if (versionNameToSelect) {
-          this.selectedVersion = versions.find(version => version.name === 
versionNameToSelect);
-        } else if (versions.length > 0) {
-          this.selectedVersion = versions[0];
-        }
-        if (this.selectedVersion) {
-          this.onVersionChange();
-        }
-        this.changeDetectorRef.detectChanges();
-      });
-  }
 }

Reply via email to