This is an automated email from the ASF dual-hosted git repository.
linxinyuan pushed a commit to branch xinyuan-dataset-selector
in repository https://gitbox.apache.org/repos/asf/texera.git
The following commit(s) were added to refs/heads/xinyuan-dataset-selector by
this push:
new ed2b3ec2fd fix fmt
ed2b3ec2fd is described below
commit ed2b3ec2fd242d8cd9a77cb1a2ff1745efb7c2a8
Author: Xinyuan Lin <[email protected]>
AuthorDate: Mon Apr 13 00:47:07 2026 -0700
fix fmt
---
.../dataset-file-selector/dataset-file-selector.component.html | 2 +-
.../dataset-file-selector/dataset-file-selector.component.ts | 6 ------
.../dataset-selection-modal.component.html | 2 +-
.../dataset-selection-modal.component.scss | 1 -
.../dataset-selection-modal/dataset-selection-modal.component.ts | 9 ---------
.../dataset-version-selector.component.ts | 1 -
6 files changed, 2 insertions(+), 19 deletions(-)
diff --git
a/frontend/src/app/workspace/component/dataset-file-selector/dataset-file-selector.component.html
b/frontend/src/app/workspace/component/dataset-file-selector/dataset-file-selector.component.html
index 75c64fc68c..34b3f8909b 100644
---
a/frontend/src/app/workspace/component/dataset-file-selector/dataset-file-selector.component.html
+++
b/frontend/src/app/workspace/component/dataset-file-selector/dataset-file-selector.component.html
@@ -17,7 +17,7 @@
under the License.
-->
<input
- *ngIf="selectedFilePath || !isFileSelectionEnabled"
+ *ngIf="this.formControl.value || !isFileSelectionEnabled"
nz-input
required
[readOnly]="isFileSelectionEnabled"
diff --git
a/frontend/src/app/workspace/component/dataset-file-selector/dataset-file-selector.component.ts
b/frontend/src/app/workspace/component/dataset-file-selector/dataset-file-selector.component.ts
index 2720e2815b..0cf5927068 100644
---
a/frontend/src/app/workspace/component/dataset-file-selector/dataset-file-selector.component.ts
+++
b/frontend/src/app/workspace/component/dataset-file-selector/dataset-file-selector.component.ts
@@ -40,7 +40,6 @@ export class DatasetFileSelectorComponent extends
FieldType<FieldTypeConfig> {
onClickOpenFileSelectionModal(): void {
const modal = this.modalService.create({
- nzTitle: "Please select one file from datasets",
nzContent: DatasetSelectionModalComponent,
nzFooter: null,
nzData: {
@@ -58,7 +57,6 @@ export class DatasetFileSelectorComponent extends
FieldType<FieldTypeConfig> {
},
nzWidth: "fit-content",
});
- // Handle the selection from the modal
modal.afterClose.pipe(untilDestroyed(this)).subscribe(selectedPath => {
if (selectedPath) {
this.formControl.setValue(selectedPath);
@@ -69,8 +67,4 @@ export class DatasetFileSelectorComponent extends
FieldType<FieldTypeConfig> {
get isFileSelectionEnabled(): boolean {
return this.config.env.selectingFilesFromDatasetsEnabled;
}
-
- get selectedFilePath(): string | null {
- return this.formControl.value;
- }
}
diff --git
a/frontend/src/app/workspace/component/dataset-selection-modal/dataset-selection-modal.component.html
b/frontend/src/app/workspace/component/dataset-selection-modal/dataset-selection-modal.component.html
index 9a341db431..ef063708d0 100644
---
a/frontend/src/app/workspace/component/dataset-selection-modal/dataset-selection-modal.component.html
+++
b/frontend/src/app/workspace/component/dataset-selection-modal/dataset-selection-modal.component.html
@@ -80,7 +80,7 @@
nzType="primary"
[disabled]="isConfirmDisabled"
(click)="onConfirmSelection()">
- {{ confirmButtonText }}
+ Select
</button>
</div>
</div>
diff --git
a/frontend/src/app/workspace/component/dataset-selection-modal/dataset-selection-modal.component.scss
b/frontend/src/app/workspace/component/dataset-selection-modal/dataset-selection-modal.component.scss
index 66765eaf64..5ce90e98cc 100644
---
a/frontend/src/app/workspace/component/dataset-selection-modal/dataset-selection-modal.component.scss
+++
b/frontend/src/app/workspace/component/dataset-selection-modal/dataset-selection-modal.component.scss
@@ -18,7 +18,6 @@
*/
:host {
- display: block;
padding: 16px;
}
diff --git
a/frontend/src/app/workspace/component/dataset-selection-modal/dataset-selection-modal.component.ts
b/frontend/src/app/workspace/component/dataset-selection-modal/dataset-selection-modal.component.ts
index ee780d8b96..a1a6880b73 100644
---
a/frontend/src/app/workspace/component/dataset-selection-modal/dataset-selection-modal.component.ts
+++
b/frontend/src/app/workspace/component/dataset-selection-modal/dataset-selection-modal.component.ts
@@ -40,7 +40,6 @@ interface ParsedDatasetVersionPath {
@UntilDestroy()
@Component({
- selector: "texera-dataset-selection-modal",
templateUrl: "dataset-selection-modal.component.html",
styleUrls: ["dataset-selection-modal.component.scss"],
})
@@ -161,10 +160,6 @@ export class DatasetSelectionModalComponent implements
OnInit {
return this._datasets;
}
- get confirmButtonText(): string {
- return this.mode === "version" ? "Select Dataset" : "Select File";
- }
-
get isConfirmDisabled(): boolean {
return this.mode === "version" ? !(this.selectedDataset &&
this.selectedVersion) : !this.selectedFileNode;
}
@@ -172,10 +167,6 @@ export class DatasetSelectionModalComponent implements
OnInit {
private parseDatasetVersionPath(path: string): ParsedDatasetVersionPath {
const parts = path.split("/").filter(part => part.length > 0);
- if (parts.length < 3) {
- throw new Error("Invalid dataset version path format");
- }
-
const [ownerEmail, datasetName, versionName] = parts;
return { ownerEmail, datasetName, versionName };
}
diff --git
a/frontend/src/app/workspace/component/dataset-version-selector/dataset-version-selector.component.ts
b/frontend/src/app/workspace/component/dataset-version-selector/dataset-version-selector.component.ts
index 2e75413115..89b0a6c677 100644
---
a/frontend/src/app/workspace/component/dataset-version-selector/dataset-version-selector.component.ts
+++
b/frontend/src/app/workspace/component/dataset-version-selector/dataset-version-selector.component.ts
@@ -34,7 +34,6 @@ export class DatasetVersionSelectorComponent extends
FieldType<FieldTypeConfig>
onClickOpenDatasetSelectionModal(): void {
const modal = this.modalService.create({
- nzTitle: "Please select a dataset version",
nzContent: DatasetSelectionModalComponent,
nzFooter: null,
nzData: {
