This is an automated email from the ASF dual-hosted git repository.
bobbai00 pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/texera.git
The following commit(s) were added to refs/heads/main by this push:
new 5446981cf4 fix(computing-unit-managing-service): pass
`AUTH_JWT_SECRET` to newly created computing units (#4426)
5446981cf4 is described below
commit 5446981cf4a3e4ac37a7d9d65bcc080d0b2a8614
Author: ali risheh <[email protected]>
AuthorDate: Mon Apr 20 14:52:56 2026 -0700
fix(computing-unit-managing-service): pass `AUTH_JWT_SECRET` to newly
created computing units (#4426)
<!--
Thanks for sending a pull request (PR)! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
[Contributing to
Texera](https://github.com/apache/texera/blob/main/CONTRIBUTING.md)
2. Ensure you have added or run the appropriate tests for your PR
3. If the PR is work in progress, mark it a draft on GitHub.
4. Please write your PR title to summarize what this PR proposes, we
are following Conventional Commits style for PR titles as well.
5. Be sure to keep the PR description updated to reflect all changes.
-->
### What changes were proposed in this PR?
<!--
Please clarify what changes you are proposing. The purpose of this
section
is to outline the changes. Here are some tips for you:
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
3. If it is a refactoring, clarify what has been changed.
3. It would be helpful to include a before-and-after comparison using
screenshots or GIFs.
4. Please consider writing useful notes for better and faster reviews.
-->
Computing units are created by calling Kubernetes functions and are
created in a separate namespace, in this regard they do not share other
services and pods settings including environment variable. In this PR we
pass `AUTH_JWT_SECRET` environment variable previously introduced in
#4388
### Any related issues, documentation, discussions?
<!--
Please use this section to link other resources if not mentioned
already.
1. If this PR fixes an issue, please include `Fixes #1234`, `Resolves
#1234`
or `Closes #1234`. If it is only related, simply mention the issue
number.
2. If there is design documentation, please add the link.
3. If there is a discussion in the mailing list, please add the link.
-->
Fixes #4425
### How was this PR tested?
<!--
If tests were added, say they were added here. Or simply mention that if
the PR
is tested with existing test cases. Make sure to include/update test
cases that
check the changes thoroughly including negative and positive cases if
possible.
If it was tested in a way different from regular unit tests, please
clarify how
you tested step by step, ideally copy and paste-able, so that other
reviewers can
test and check, and descendants can verify in the future. If tests were
not added,
please describe why they were not added and/or why it was difficult to
add.
-->
Tested using the k8s deployment
### Was this PR authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this
PR,
please include the phrase: 'Generated-by: ' followed by the name of the
tool
and its version. If no, write 'No'.
Please refer to the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) for
details.
-->
No
---------
Co-authored-by: Chen Li <[email protected]>
---
.../scala/org/apache/texera/amber/config/EnvironmentalVariable.scala | 1 +
.../apache/texera/service/resource/ComputingUnitManagingResource.scala | 3 +++
2 files changed, 4 insertions(+)
diff --git
a/common/config/src/main/scala/org/apache/texera/amber/config/EnvironmentalVariable.scala
b/common/config/src/main/scala/org/apache/texera/amber/config/EnvironmentalVariable.scala
index 339b57f52a..9ec52bba65 100644
---
a/common/config/src/main/scala/org/apache/texera/amber/config/EnvironmentalVariable.scala
+++
b/common/config/src/main/scala/org/apache/texera/amber/config/EnvironmentalVariable.scala
@@ -43,6 +43,7 @@ object EnvironmentalVariable {
* Auth related vars
*/
val ENV_USER_JWT_TOKEN = "USER_JWT_TOKEN"
+ val ENV_AUTH_JWT_SECRET = "AUTH_JWT_SECRET"
// JDBC
val ENV_JDBC_URL = "STORAGE_JDBC_URL"
diff --git
a/computing-unit-managing-service/src/main/scala/org/apache/texera/service/resource/ComputingUnitManagingResource.scala
b/computing-unit-managing-service/src/main/scala/org/apache/texera/service/resource/ComputingUnitManagingResource.scala
index 9b214b9755..bc4aa32ef2 100644
---
a/computing-unit-managing-service/src/main/scala/org/apache/texera/service/resource/ComputingUnitManagingResource.scala
+++
b/computing-unit-managing-service/src/main/scala/org/apache/texera/service/resource/ComputingUnitManagingResource.scala
@@ -103,6 +103,9 @@ object ComputingUnitManagingResource {
.get,
EnvironmentalVariable.ENV_MAX_WORKFLOW_WEBSOCKET_REQUEST_PAYLOAD_SIZE_KB
-> EnvironmentalVariable
.get(EnvironmentalVariable.ENV_MAX_WORKFLOW_WEBSOCKET_REQUEST_PAYLOAD_SIZE_KB)
+ .get,
+ EnvironmentalVariable.ENV_AUTH_JWT_SECRET -> EnvironmentalVariable
+ .get(EnvironmentalVariable.ENV_AUTH_JWT_SECRET)
.get
)
