This is an automated email from the ASF dual-hosted git repository.
aglinxinyuan pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/texera.git
The following commit(s) were added to refs/heads/main by this push:
new c2af3b8fea fix(backend): add missing backend handler for dataset
rename (#4416)
c2af3b8fea is described below
commit c2af3b8fea9a8aad705fd59474fa3827da25ef55
Author: Seongjin Yoon <[email protected]>
AuthorDate: Fri May 1 22:53:33 2026 -0700
fix(backend): add missing backend handler for dataset rename (#4416)
<!--
Thanks for sending a pull request (PR)! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
[Contributing to
Texera](https://github.com/apache/texera/blob/main/CONTRIBUTING.md)
2. Ensure you have added or run the appropriate tests for your PR
3. If the PR is work in progress, mark it a draft on GitHub.
4. Please write your PR title to summarize what this PR proposes, we
are following Conventional Commits style for PR titles as well.
5. Be sure to keep the PR description updated to reflect all changes.
-->
### What changes were proposed in this PR?
<!--
Please clarify what changes you are proposing. The purpose of this
section
is to outline the changes. Here are some tips for you:
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
3. If it is a refactoring, clarify what has been changed.
3. It would be helpful to include a before-and-after comparison using
screenshots or GIFs.
4. Please consider writing useful notes for better and faster reviews.
-->
**Root Cause:**
Renaming a dataset returned 404 because the backend handler was not
implemented. The frontend posts to `/dataset/update/name` with {did,
name}, but `DatasetResource.scala` never defined a handler at that path.
**Fix:**
Added `DatasetNameModification(did, name)` case class for the new
endpoint, pairing the dataset id with the new display name.
Added `@POST @Path("/update/name")` handler that renames a dataset's
display name, gated by a write-access check.
https://github.com/user-attachments/assets/17c99461-e589-42e0-8eed-5909051c9aeb
### Any related issues, documentation, discussions?
<!--
Please use this section to link other resources if not mentioned
already.
1. If this PR fixes an issue, please include `Fixes #1234`, `Resolves
#1234`
or `Closes #1234`. If it is only related, simply mention the issue
number.
2. If there is design documentation, please add the link.
3. If there is a discussion in the mailing list, please add the link.
-->
#3551
The handler used to exist. It was added in #2391 and it seems to have
been working after #3048. It was then deleted by #3314 ("Remove the
redundant dataset endpoints"), which removed ~998 lines from
`amber/.../DatasetResource.scala` including the renaming of the dataset.
It seems the bug has been latent since #3314 merged.
### How was this PR tested?
<!--
If tests were added, say they were added here. Or simply mention that if
the PR
is tested with existing test cases. Make sure to include/update test
cases that
check the changes thoroughly including negative and positive cases if
possible.
If it was tested in a way different from regular unit tests, please
clarify how
you tested step by step, ideally copy and paste-able, so that other
reviewers can
test and check, and descendants can verify in the future. If tests were
not added,
please describe why they were not added and/or why it was difficult to
add.
-->
Manually tested.
### Was this PR authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this
PR,
please include the phrase: 'Generated-by: ' followed by the name of the
tool
and its version. If no, write 'No'.
Please refer to the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) for
details.
-->
Revised with Claude Code.
---------
Co-authored-by: Xinyuan Lin <[email protected]>
Co-authored-by: Chen Li <[email protected]>
---
.../texera/service/resource/DatasetResource.scala | 25 ++++++++
.../service/resource/DatasetResourceSpec.scala | 70 ++++++++++++++++++++++
2 files changed, 95 insertions(+)
diff --git
a/file-service/src/main/scala/org/apache/texera/service/resource/DatasetResource.scala
b/file-service/src/main/scala/org/apache/texera/service/resource/DatasetResource.scala
index ad5f224720..9832cbbf64 100644
---
a/file-service/src/main/scala/org/apache/texera/service/resource/DatasetResource.scala
+++
b/file-service/src/main/scala/org/apache/texera/service/resource/DatasetResource.scala
@@ -209,6 +209,8 @@ object DatasetResource {
case class DatasetDescriptionModification(did: Integer, description: String)
+ case class DatasetNameModification(did: Integer, name: String)
+
case class DatasetVersionRootFileNodesResponse(
fileNodes: List[DatasetFileNode],
size: Long
@@ -493,6 +495,29 @@ class DatasetResource {
}
}
+ @POST
+ @Consumes(Array(MediaType.APPLICATION_JSON))
+ @Produces(Array(MediaType.APPLICATION_JSON))
+ @RolesAllowed(Array("REGULAR", "ADMIN"))
+ @Path("/update/name")
+ def updateDatasetName(
+ modificator: DatasetNameModification,
+ @Auth sessionUser: SessionUser
+ ): Response = {
+ withTransaction(context) { ctx =>
+ val uid = sessionUser.getUid
+ val datasetDao = new DatasetDao(ctx.configuration())
+ val dataset = getDatasetByID(ctx, modificator.did)
+ if (!userHasWriteAccess(ctx, modificator.did, uid)) {
+ throw new ForbiddenException(ERR_USER_HAS_NO_ACCESS_TO_DATASET_MESSAGE)
+ }
+
+ dataset.setName(modificator.name)
+ datasetDao.update(dataset)
+ Response.ok().build()
+ }
+ }
+
@POST
@RolesAllowed(Array("REGULAR", "ADMIN"))
@Path("/{did}/upload")
diff --git
a/file-service/src/test/scala/org/apache/texera/service/resource/DatasetResourceSpec.scala
b/file-service/src/test/scala/org/apache/texera/service/resource/DatasetResourceSpec.scala
index 7c94dc8fe9..e4f1e74f6c 100644
---
a/file-service/src/test/scala/org/apache/texera/service/resource/DatasetResourceSpec.scala
+++
b/file-service/src/test/scala/org/apache/texera/service/resource/DatasetResourceSpec.scala
@@ -370,6 +370,76 @@ class DatasetResourceSpec
datasetDao.fetchOneByDid(dataset.getDid) should not be null
}
+ "updateDatasetName" should "rename dataset successfully if user has write
access" in {
+ val dataset = new Dataset
+ dataset.setName("rename-before")
+ dataset.setRepositoryName("rename-before-repo")
+ dataset.setDescription("for rename happy path")
+ dataset.setOwnerUid(ownerUser.getUid)
+ dataset.setIsPublic(true)
+ dataset.setIsDownloadable(true)
+ datasetDao.insert(dataset)
+
+ val response = datasetResource.updateDatasetName(
+ DatasetResource.DatasetNameModification(dataset.getDid, "rename-after"),
+ sessionUser
+ )
+
+ response.getStatus shouldEqual 200
+ datasetDao.fetchOneByDid(dataset.getDid).getName shouldEqual "rename-after"
+ }
+
+ it should "refuse to rename dataset if user lacks write access" in {
+ val dataset = new Dataset
+ dataset.setName("rename-forbidden")
+ dataset.setRepositoryName("rename-forbidden-repo")
+ dataset.setDescription("for rename forbidden test")
+ dataset.setOwnerUid(ownerUser.getUid)
+ dataset.setIsPublic(true)
+ dataset.setIsDownloadable(true)
+ datasetDao.insert(dataset)
+
+ assertThrows[ForbiddenException] {
+ datasetResource.updateDatasetName(
+ DatasetResource.DatasetNameModification(dataset.getDid, "hijacked"),
+ sessionUser2
+ )
+ }
+
+ datasetDao.fetchOneByDid(dataset.getDid).getName shouldEqual
"rename-forbidden"
+ }
+
+ it should "throw NotFoundException when renaming a non-existent dataset" in {
+ val nonExistentDid: Integer = Int.box(Int.MaxValue)
+
+ assertThrows[NotFoundException] {
+ datasetResource.updateDatasetName(
+ DatasetResource.DatasetNameModification(nonExistentDid, "ghost"),
+ sessionUser
+ )
+ }
+ }
+
+ it should "leave repository_name unchanged after rename" in {
+ val dataset = new Dataset
+ dataset.setName("rename-keeps-repo")
+ dataset.setRepositoryName("rename-keeps-repo-stable")
+ dataset.setDescription("for repo-name invariance test")
+ dataset.setOwnerUid(ownerUser.getUid)
+ dataset.setIsPublic(true)
+ dataset.setIsDownloadable(true)
+ datasetDao.insert(dataset)
+
+ datasetResource.updateDatasetName(
+ DatasetResource.DatasetNameModification(dataset.getDid,
"rename-keeps-repo-renamed"),
+ sessionUser
+ )
+
+ val reloaded = datasetDao.fetchOneByDid(dataset.getDid)
+ reloaded.getName shouldEqual "rename-keeps-repo-renamed"
+ reloaded.getRepositoryName shouldEqual "rename-keeps-repo-stable"
+ }
+
//
===========================================================================
// Multipart upload tests (merged in)
//
===========================================================================
