(texera) branch main updated: test(amber): add unit test coverage for LinkExecution (#4753)

[yiconghuang]

This is an automated email from the ASF dual-hosted git repository.

Yicong-Huang pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/texera.git


The following commit(s) were added to refs/heads/main by this push:
     new 7e2163f56e test(amber): add unit test coverage for LinkExecution 
(#4753)
7e2163f56e is described below

commit 7e2163f56ea904e57c4db28682bbfef16237f61c
Author: Xinyuan Lin <xinyu...@uci.edu>
AuthorDate: Sun May 3 05:15:07 2026 -0700

    test(amber): add unit test coverage for LinkExecution (#4753)
    
    ### What changes were proposed in this PR?
    
    Add `LinkExecutionSpec` covering the per-link channel-execution tracker
    in `LinkExecution`:
    
    - A fresh `LinkExecution` exposes no channel executions
    - `initChannelExecution` registers a new `ChannelExecution` for the
    given channel id
    - A second `initChannelExecution` for the same channel id raises an
    `AssertionError`
    - Multiple distinct channel ids are tracked independently
    
    ### Any related issues, documentation, discussions?
    
    Closes #4752
    
    ### How was this PR tested?
    
    `sbt "WorkflowExecutionService/testOnly
    
org.apache.texera.amber.engine.architecture.controller.execution.LinkExecutionSpec"`
    — 4/4 tests pass.
    
    ### Was this PR authored or co-authored using generative AI tooling?
    
    Generated-by: Claude Code (Claude Opus 4.7)
    
    Co-authored-by: Claude Opus 4.7 (1M context) <nore...@anthropic.com>
---
 .../controller/execution/LinkExecutionSpec.scala   | 66 ++++++++++++++++++++++
 1 file changed, 66 insertions(+)

diff --git 
a/amber/src/test/scala/org/apache/texera/amber/engine/architecture/controller/execution/LinkExecutionSpec.scala
 
b/amber/src/test/scala/org/apache/texera/amber/engine/architecture/controller/execution/LinkExecutionSpec.scala
new file mode 100644
index 0000000000..443a31c2b4
--- /dev/null
+++ 
b/amber/src/test/scala/org/apache/texera/amber/engine/architecture/controller/execution/LinkExecutionSpec.scala
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.texera.amber.engine.architecture.controller.execution
+
+import org.apache.texera.amber.core.virtualidentity.{ActorVirtualIdentity, 
ChannelIdentity}
+import org.scalatest.flatspec.AnyFlatSpec
+
+class LinkExecutionSpec extends AnyFlatSpec {
+
+  private def channelId(from: String, to: String, isControl: Boolean = false): 
ChannelIdentity =
+    ChannelIdentity(ActorVirtualIdentity(from), ActorVirtualIdentity(to), 
isControl)
+
+  "LinkExecution" should "have no channel executions when freshly constructed" 
in {
+    val link = LinkExecution()
+    assert(link.getAllChannelExecutions.isEmpty)
+  }
+
+  "LinkExecution.initChannelExecution" should "register a new ChannelExecution 
for the given channel id" in {
+    val link = LinkExecution()
+    val cid = channelId("a", "b")
+    link.initChannelExecution(cid)
+
+    val all = link.getAllChannelExecutions.toMap
+    assert(all.contains(cid))
+    assert(all(cid) == ChannelExecution())
+  }
+
+  it should "throw an AssertionError if called twice for the same channel id" 
in {
+    val link = LinkExecution()
+    val cid = channelId("a", "b")
+    link.initChannelExecution(cid)
+    assertThrows[AssertionError] {
+      link.initChannelExecution(cid)
+    }
+  }
+
+  it should "track multiple distinct channel executions" in {
+    val link = LinkExecution()
+    val c1 = channelId("a", "b")
+    val c2 = channelId("a", "b", isControl = true)
+    val c3 = channelId("a", "c")
+
+    link.initChannelExecution(c1)
+    link.initChannelExecution(c2)
+    link.initChannelExecution(c3)
+
+    assert(link.getAllChannelExecutions.toMap.keySet == Set(c1, c2, c3))
+  }
+}