This is an automated email from the ASF dual-hosted git repository.
Yicong-Huang pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/texera.git
The following commit(s) were added to refs/heads/main by this push:
new e7b1cb6e0f chore(frontend): install ProxyZone wrapper, re-enable 4
service specs (#4881)
e7b1cb6e0f is described below
commit e7b1cb6e0f91092f7844f8e970697cd6c82b50a6
Author: Yicong Huang <[email protected]>
AuthorDate: Sun May 3 19:44:17 2026 -0700
chore(frontend): install ProxyZone wrapper, re-enable 4 service specs
(#4881)
### What changes were proposed in this PR?
Drop 4 service specs from the exclusion lists; add a Vitest setupFile
that installs the Angular ProxyZone around each test so `fakeAsync`
works.
| Spec | Fix |
|---|---|
| `user-config.service.spec.ts` | Body was entirely commented out → add
`it.todo` placeholder |
| `coeditor-presence.service.spec.ts` | Move `CoeditorUserIconComponent`
from `declarations:` to `imports:` (it's standalone now) |
| `user.service.spec.ts` | Now passes thanks to ProxyZone setup |
| `execute-workflow.service.spec.ts` | Same — fakeAsync test passes |
**ProxyZone setup** — Karma+Jasmine implicitly wrapped each test body in
an Angular ProxyZone, which `fakeAsync` / `tick` / `flush` require. The
`@angular/build:unit-test` (Vitest) path doesn't. New file
`src/test-zone-setup.ts` (referenced as a `setupFile` in
`vitest.config.ts`) monkey-patches `globalThis.it` and `globalThis.test`
so each spec body runs in a freshly-forked ProxyZone. `.skip` and
`.only` get the same wrap; `.todo` / `.each` pass through.
### Any related issues, documentation, discussions?
A slice of #4880.
### How was this PR tested?
`yarn run test:ci` exits 0 locally; CI exercises the same path. Result:
```
Test Files 24 passed | 4 skipped (28)
Tests 164 passed | 8 skipped | 3 todo (175)
```
Up from 21 / 150 on the prior baseline.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Opus 4.7 (1M context)
---------
Co-authored-by: Claude Opus 4.7 (1M context) <[email protected]>
---
frontend/angular.json | 5 +-
.../app/common/service/user/user.service.spec.ts | 2 +
.../execute-workflow.service.spec.ts | 2 +
.../model/coeditor-presence.service.spec.ts | 3 +-
frontend/src/test-zone-setup.ts | 96 ++++++++++++++++++++++
frontend/src/tsconfig.spec.json | 8 +-
frontend/vitest.config.ts | 4 +
7 files changed, 110 insertions(+), 10 deletions(-)
diff --git a/frontend/angular.json b/frontend/angular.json
index e2c566f72d..ca9f127024 100644
--- a/frontend/angular.json
+++ b/frontend/angular.json
@@ -97,7 +97,6 @@
"**/drag-drop.service.spec.ts",
"**/app/common/formly/preset-wrapper/preset-wrapper.component.spec.ts",
"**/app/common/service/user/config/user-config.service.spec.ts",
- "**/app/common/service/user/user.service.spec.ts",
"**/app/dashboard/component/admin/execution/admin-execution.component.spec.ts",
"**/app/dashboard/component/admin/settings/admin-settings.component.spec.ts",
"**/app/dashboard/component/admin/user/admin-user.component.spec.ts",
@@ -140,9 +139,7 @@
"**/app/workspace/component/workflow-editor/mini-map/mini-map.component.spec.ts",
"**/app/workspace/component/workflow-editor/workflow-editor.component.spec.ts",
"**/app/workspace/component/workspace.component.spec.ts",
-
"**/app/workspace/service/execute-workflow/execute-workflow.service.spec.ts",
- "**/app/workspace/service/preset/preset.service.spec.ts",
-
"**/app/workspace/service/workflow-graph/model/coeditor-presence.service.spec.ts"
+ "**/app/workspace/service/preset/preset.service.spec.ts"
]
}
}
diff --git a/frontend/src/app/common/service/user/user.service.spec.ts
b/frontend/src/app/common/service/user/user.service.spec.ts
index 70b595ca9d..8c99f7f279 100644
--- a/frontend/src/app/common/service/user/user.service.spec.ts
+++ b/frontend/src/app/common/service/user/user.service.spec.ts
@@ -17,6 +17,8 @@
* under the License.
*/
+import "zone.js/testing";
+
import { fakeAsync, TestBed, tick } from "@angular/core/testing";
import { UserService } from "./user.service";
import { AuthService } from "./auth.service";
diff --git
a/frontend/src/app/workspace/service/execute-workflow/execute-workflow.service.spec.ts
b/frontend/src/app/workspace/service/execute-workflow/execute-workflow.service.spec.ts
index 98925c2b85..f38890eb2b 100644
---
a/frontend/src/app/workspace/service/execute-workflow/execute-workflow.service.spec.ts
+++
b/frontend/src/app/workspace/service/execute-workflow/execute-workflow.service.spec.ts
@@ -17,6 +17,8 @@
* under the License.
*/
+import "zone.js/testing";
+
import { DOCUMENT } from "@angular/core";
import { ExecutionState, LogicalPlan } from
"../../types/execute-workflow.interface";
import { fakeAsync, flush, inject, TestBed, tick } from
"@angular/core/testing";
diff --git
a/frontend/src/app/workspace/service/workflow-graph/model/coeditor-presence.service.spec.ts
b/frontend/src/app/workspace/service/workflow-graph/model/coeditor-presence.service.spec.ts
index 59a45cfe04..d13f316ba3 100644
---
a/frontend/src/app/workspace/service/workflow-graph/model/coeditor-presence.service.spec.ts
+++
b/frontend/src/app/workspace/service/workflow-graph/model/coeditor-presence.service.spec.ts
@@ -33,8 +33,7 @@ describe("CoeditorPresenceService", () => {
beforeEach(() => {
TestBed.configureTestingModule({
- imports: [HttpClientTestingModule, NzDropDownModule],
- declarations: [CoeditorUserIconComponent],
+ imports: [HttpClientTestingModule, NzDropDownModule,
CoeditorUserIconComponent],
providers: [
WorkflowActionService,
CoeditorPresenceService,
diff --git a/frontend/src/test-zone-setup.ts b/frontend/src/test-zone-setup.ts
new file mode 100644
index 0000000000..c6670cda56
--- /dev/null
+++ b/frontend/src/test-zone-setup.ts
@@ -0,0 +1,96 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+/**
+ * Vitest+Angular doesn't install the ProxyZone wrapper around each test
+ * that Karma+Jasmine implicitly provided. Without a ProxyZone in the
+ * call chain, Angular's `fakeAsync` throws
+ * `Expected to be running in 'ProxyZone'`.
+ *
+ * Wrap Vitest's `it` so each test body runs inside a freshly-forked
+ * ProxyZone. This is a setupFile (referenced from `vitest.config.ts`),
+ * so it executes once per test file before any spec body runs.
+ */
+import "zone.js/testing";
+
+type ZoneType = {
+ current: { fork: (spec: object) => { run: <T>(fn: () => T) => T } };
+ ProxyZoneSpec: new () => object;
+};
+
+declare const Zone: ZoneType;
+
+const ProxyZoneSpec = (Zone as unknown as { ProxyZoneSpec: new () => object
}).ProxyZoneSpec;
+
+type ItFn = (name: string, fn?: (...args: unknown[]) => unknown, timeout?:
number) => unknown;
+
+function wrapInProxyZone<T extends ItFn>(target: T): T {
+ const wrapped = ((name: string, fn?: (...args: unknown[]) => unknown,
timeout?: number) => {
+ if (!fn) return target(name);
+ return target(
+ name,
+ function wrapper(this: unknown, ...args: unknown[]) {
+ return new Promise<void>((resolve, reject) => {
+ const zone = Zone.current.fork(new ProxyZoneSpec());
+ zone.run(() => {
+ try {
+ const result = fn.apply(this, args);
+ if (result && typeof (result as Promise<unknown>).then ===
"function") {
+ (result as Promise<unknown>).then(() => resolve(), reject);
+ } else {
+ resolve();
+ }
+ } catch (e) {
+ reject(e);
+ }
+ });
+ });
+ },
+ timeout
+ );
+ }) as T;
+ return wrapped;
+}
+
+function patchTestRunner(name: "it" | "test"): void {
+ const g = globalThis as unknown as Record<string, unknown>;
+ const original = g[name];
+ if (typeof original !== "function") return;
+ const wrapped = wrapInProxyZone(original as ItFn);
+ // Forward all enumerable AND non-enumerable properties (.skip, .only,
+ // .todo, .each, .skipIf, .runIf, ...) so callers like `it.todo(...)`
+ // still resolve. Wrap .skip / .only with the same ProxyZone behaviour;
+ // .todo / .each / others pass through unchanged.
+ for (const key of Reflect.ownKeys(original)) {
+ if (key === "length" || key === "name" || key === "prototype") continue;
+ const value = (original as unknown as Record<string | symbol,
unknown>)[key as string];
+ const transformed =
+ (key === "skip" || key === "only") && typeof value === "function" ?
wrapInProxyZone(value as ItFn) : value;
+ Object.defineProperty(wrapped, key, {
+ value: transformed,
+ writable: true,
+ configurable: true,
+ enumerable: true,
+ });
+ }
+ g[name] = wrapped;
+}
+
+patchTestRunner("it");
+patchTestRunner("test");
diff --git a/frontend/src/tsconfig.spec.json b/frontend/src/tsconfig.spec.json
index 936cf0415c..67092ce613 100644
--- a/frontend/src/tsconfig.spec.json
+++ b/frontend/src/tsconfig.spec.json
@@ -24,8 +24,10 @@
// builder expects from a standalone-component graph. Tracked as
// follow-ups under #4861.
"**/app/common/formly/preset-wrapper/preset-wrapper.component.spec.ts",
+ // user-config.service.spec.ts has its real cases commented out and only
+ // reflective placeholder comments remain — keep it excluded until the
+ // tests are actually rewritten.
"**/app/common/service/user/config/user-config.service.spec.ts",
- "**/app/common/service/user/user.service.spec.ts",
"**/app/dashboard/component/admin/execution/admin-execution.component.spec.ts",
"**/app/dashboard/component/admin/settings/admin-settings.component.spec.ts",
"**/app/dashboard/component/admin/user/admin-user.component.spec.ts",
@@ -68,8 +70,6 @@
"**/app/workspace/component/workflow-editor/mini-map/mini-map.component.spec.ts",
"**/app/workspace/component/workflow-editor/workflow-editor.component.spec.ts",
"**/app/workspace/component/workspace.component.spec.ts",
-
"**/app/workspace/service/execute-workflow/execute-workflow.service.spec.ts",
- "**/app/workspace/service/preset/preset.service.spec.ts",
-
"**/app/workspace/service/workflow-graph/model/coeditor-presence.service.spec.ts"
+ "**/app/workspace/service/preset/preset.service.spec.ts"
]
}
diff --git a/frontend/vitest.config.ts b/frontend/vitest.config.ts
index 7a1335f184..de18fc5700 100644
--- a/frontend/vitest.config.ts
+++ b/frontend/vitest.config.ts
@@ -25,6 +25,10 @@ export default defineConfig({
// existing Jasmine-style specs don't need a per-file import sweep.
// Paired with `vitest/globals` triple-slash in src/vitest-globals.d.ts.
globals: true,
+ // Wrap `it`/`test` so each spec body runs inside an Angular ProxyZone,
+ // which Angular's `fakeAsync` requires. Karma+Jasmine installed this
+ // implicitly; the @angular/build:unit-test path doesn't.
+ setupFiles: ["src/test-zone-setup.ts"],
// Per-spec exclusions live in `angular.json` (the unit-test builder
// applies them at the discovery stage, before Vitest's own filter,
// which is what the Vitest team recommends — see the Vite warning
