The GitHub Actions job "Required Checks" on texera.git/test-network-output-buffer-spec has succeeded. Run started by GitHub user aglinxinyuan (triggered by aglinxinyuan).
Head commit for run: 8ba25f084e09ac97fecf186d060e34c4113bb3ff / Xinyuan Lin <[email protected]> test(amber): pin desired batchSize<=0 rejection (pendingUntilFixed) Address Copilot follow-up on #4958: my previous NOTE claimed batchSize=0 was not reachable from production because the workflow- settings UI restricts the value to >= 1. That was inaccurate — SyncExecutionResource accepts request.workflowSettings directly from the API and the backend forwards workflowSettings.dataTransferBatchSize into NetworkOutputBuffer with no server-side validation, so a malicious or buggy API caller can reach batchSize=0 today. Replace the misleading NOTE with: - An accurate comment block describing the actual reachability (server-side API path, no validation). - A pendingUntilFixed test asserting the desired hardening: construction with batchSize <= 0 should throw IllegalArgumentException (e.g. via a require(batchSize > 0, ...) guard). Today this test is pending because the constructor accepts non-positive values; once the hardening lands the assertion will pass and pendingUntilFixed will invert that into a deliberate failure forcing the marker to be removed. Report URL: https://github.com/apache/texera/actions/runs/25409772379 With regards, GitHub Actions via GitBox
