This is an automated email from the ASF dual-hosted git repository.
aglinxinyuan pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/texera.git
The following commit(s) were added to refs/heads/main by this push:
new b4f3a41a2c chore(deps): drop unused content-disposition dependency
(#4980)
b4f3a41a2c is described below
commit b4f3a41a2cd8be987569aa5d9fc35f40b0854d69
Author: Xinyuan Lin <[email protected]>
AuthorDate: Thu May 7 23:33:02 2026 -0700
chore(deps): drop unused content-disposition dependency (#4980)
### What changes were proposed in this PR?
`download.service.ts` carried a top-level `var contentDisposition =
require("content-disposition")` that was never read or called. Removing
the dead `require` lets us drop the `content-disposition` runtime dep
and its `@types/content-disposition` companion, plus the now-stale
bundled-license entries for the transitive packages that fell out with
it (`base64-js`, `buffer`, `ieee754`, `path-browserify`, `safe-buffer`).
### Any related issues, documentation, discussions?
Closes #4979.
### How was this PR tested?
- `yarn install` succeeds and rewrites `yarn.lock` (transitive entries
fall away)
- `yarn build` exits 0
- `yarn test` stays at 63 / 269 parity
- CI's `check_binary_deps.py --ignore-transitive-version npm
…/3rdpartylicenses.json` will be the final arbiter on the LICENSE-binary
cleanup
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.7)
---
frontend/LICENSE-binary | 6 ------
frontend/package.json | 2 --
.../service/user/download/download.service.ts | 2 --
frontend/yarn.lock | 25 +++++++---------------
4 files changed, 8 insertions(+), 27 deletions(-)
diff --git a/frontend/LICENSE-binary b/frontend/LICENSE-binary
index bee43c7b6b..3cfe8bab21 100644
--- a/frontend/LICENSE-binary
+++ b/frontend/LICENSE-binary
@@ -274,10 +274,7 @@ Angular / npm packages:
- [email protected]
- [email protected]
- [email protected]
- - [email protected]
- [email protected]
- - [email protected]
- - [email protected]
- [email protected]
- [email protected]
- [email protected]
@@ -304,7 +301,6 @@ Angular / npm packages:
- [email protected]
- [email protected]
- [email protected]
- - [email protected]
- [email protected]
- [email protected]
- [email protected]
@@ -313,7 +309,6 @@ Angular / npm packages:
- [email protected]
- [email protected]
- [email protected]
- - [email protected]
- [email protected]
- [email protected]
- [email protected]
@@ -338,7 +333,6 @@ Dependencies under the BSD 3-Clause License
Angular / npm packages:
- [email protected]
- - [email protected]
- [email protected]
--------------------------------------------------------------------------------
diff --git a/frontend/package.json b/frontend/package.json
index c1f0231aec..3f3b3b3fad 100644
--- a/frontend/package.json
+++ b/frontend/package.json
@@ -44,7 +44,6 @@
"ai": "5.0.93",
"ajv": "8.10.0",
"concaveman": "2.0.0",
- "content-disposition": "0.5.4",
"d3-shape": "2.1.0",
"dagre": "0.8.5",
"file-saver": "2.0.5",
@@ -103,7 +102,6 @@
"@schematics/angular": "21.2.8",
"@types/backbone": "1.4.15",
"@types/concaveman": "1.1.6",
- "@types/content-disposition": "0",
"@types/d3-shape": "2.1.2",
"@types/dagre": "0.7.47",
"@types/file-saver": "2.0.5",
diff --git
a/frontend/src/app/dashboard/service/user/download/download.service.ts
b/frontend/src/app/dashboard/service/user/download/download.service.ts
index 0e202e0c26..811ebe37f4 100644
--- a/frontend/src/app/dashboard/service/user/download/download.service.ts
+++ b/frontend/src/app/dashboard/service/user/download/download.service.ts
@@ -31,8 +31,6 @@ import { WORKFLOW_EXECUTIONS_API_BASE_URL } from
"../workflow-executions/workflo
import { DashboardWorkflowComputingUnit } from
"../../../../common/type/workflow-computing-unit";
import { TOKEN_KEY } from "../../../../common/service/user/auth.service";
-var contentDisposition = require("content-disposition");
-
export const EXPORT_BASE_URL = "result/export";
const IFRAME_TIMEOUT_MS = 10000;
export const DOWNLOADABILITY_BASE_URL = "result/downloadability";
diff --git a/frontend/yarn.lock b/frontend/yarn.lock
index dca7469bbd..d2fff7e05c 100644
--- a/frontend/yarn.lock
+++ b/frontend/yarn.lock
@@ -5908,13 +5908,6 @@ __metadata:
languageName: node
linkType: hard
-"@types/content-disposition@npm:0":
- version: 0.5.9
- resolution: "@types/content-disposition@npm:0.5.9"
- checksum:
10c0/9fd520dae1a9c7b85909e59f548f905a670a6e2f83642f9734d1b05126f64ac8c8e2c282a663edf27d58bc34fbbacf46a4d4a95d3802b42106174a19a68175c8
- languageName: node
- linkType: hard
-
"@types/d3-path@npm:^2":
version: 2.0.4
resolution: "@types/d3-path@npm:2.0.4"
@@ -8447,7 +8440,14 @@ __metadata:
languageName: node
linkType: hard
-"content-disposition@npm:0.5.4, content-disposition@npm:~0.5.4":
+"content-disposition@npm:^1.0.0":
+ version: 1.1.0
+ resolution: "content-disposition@npm:1.1.0"
+ checksum:
10c0/94e0aef65873e69330f5f187fbc44ebce593bdcb8013dd8a68b7d0f159ca089bd30db3f8095d829f81c341695b60a6085ee6e15e6d775c4a325b586cc8d91974
+ languageName: node
+ linkType: hard
+
+"content-disposition@npm:~0.5.4":
version: 0.5.4
resolution: "content-disposition@npm:0.5.4"
dependencies:
@@ -8456,13 +8456,6 @@ __metadata:
languageName: node
linkType: hard
-"content-disposition@npm:^1.0.0":
- version: 1.1.0
- resolution: "content-disposition@npm:1.1.0"
- checksum:
10c0/94e0aef65873e69330f5f187fbc44ebce593bdcb8013dd8a68b7d0f159ca089bd30db3f8095d829f81c341695b60a6085ee6e15e6d775c4a325b586cc8d91974
- languageName: node
- linkType: hard
-
"content-type@npm:^1.0.5, content-type@npm:~1.0.4, content-type@npm:~1.0.5":
version: 1.0.5
resolution: "content-type@npm:1.0.5"
@@ -10865,7 +10858,6 @@ __metadata:
"@schematics/angular": "npm:21.2.8"
"@types/backbone": "npm:1.4.15"
"@types/concaveman": "npm:1.1.6"
- "@types/content-disposition": "npm:0"
"@types/d3-shape": "npm:2.1.2"
"@types/dagre": "npm:0.7.47"
"@types/file-saver": "npm:2.0.5"
@@ -10887,7 +10879,6 @@ __metadata:
ajv: "npm:8.10.0"
concaveman: "npm:2.0.0"
concurrently: "npm:7.4.0"
- content-disposition: "npm:0.5.4"
d3-shape: "npm:2.1.0"
dagre: "npm:0.8.5"
eslint: "npm:8.57.0"
