The GitHub Actions job "License Binary Checker" on texera.git/main has failed.
Run started by GitHub user bobbai00 (triggered by bobbai00).

Head commit for run:
538ae1d5cb9027b34b29e99d33c2c286970b29b1 / Matthew B. <[email protected]>
fix: reject hyphenated layer names in createWorkerIdentity (#5051)

### What changes were proposed in this PR?
`VirtualIdentityUtils.createWorkerIdentity` now rejects layer names
containing `-` via `require`. The worker-name format
`Worker:WF<id>-<op>-<layer>-<workerId>` is inherently ambiguous when
both `op` and `layer` may contain `-`, and production operator IDs (e.g.
`ClassName-UUID`) structurally must. Layer names in production are
always hyphen-free (`main`, `build`, `probe`, `localAgg`, `globalAgg`);
this change lifts that invariant from "implied by the regex" to
"enforced at the boundary", so callers fail loudly at construction
instead of silently mis-parsing later. Two `WorkerSpec` test fixtures
(`"1st-physical-op"`, `"2nd physical-op"`) are renamed to hyphen-free
equivalents; they only needed to be two distinct strings.
  ### Any related issues, documentation, or discussions?
Closes: #4728 
### How was this PR tested?
The previously-pinned `VirtualIdentityUtilsSpec` bug spec ("misparse
layer names that contain hyphens (current behavior)") is replaced with a
spec asserting that `createWorkerIdentity` rejects hyphenated layer
names. Existing `VirtualIdentityUtilsSpec`, `WorkerSpec`, and the Python
`test_virtual_identity.py` cases continue to pass (Python's
`get_worker_index` only extracts the trailing index group and is
unaffected).
### Was this PR authored or co-authored using generative AI tooling?
  Co-authored with Claude Opus 4.7 in compliance with ASF

Co-authored-by: ali risheh <[email protected]>

Report URL: https://github.com/apache/texera/actions/runs/26160924089

With regards,
GitHub Actions via GitBox

Reply via email to