The GitHub Actions job "Required Checks" on texera.git/bench/arrow-flight-e2e has failed. Run started by GitHub user Yicong-Huang (triggered by Yicong-Huang).
Head commit for run: 5976a30dd511086aec0722e9f314892149ba66f3 / Yicong Huang <[email protected]> feat(bench): post bench results as PR comment + tidy CI naming Three things: 1. Rename bench job's display name to `Bench` (was lowercase `bench`). 2. Bench job → Python 3.12 (was 3.11). Matches the local dev venv and the runtime Python texera_run_python_worker.py spawns; consistency removes a class of "works locally, drifts in CI" surprises. 3. PR-side comment with bench results. The Benchmarks workflow runs on `pull_request` events from forks, where GitHub forces GITHUB_TOKEN to read-only and refuses to inject any secret (AUTO_MERGE_TOKEN included — that restriction applies to ALL secrets, not just GITHUB_TOKEN). The fix is the ASF-approved `workflow_run` pattern: a separate workflow file that triggers when Benchmarks completes, runs in the base repo's trusted context, and has `pull-requests: write`. Bench-side: write the PR number to bench-results/pr-number.txt (workflow_run.pull_requests is empty for fork PRs, so we ferry the number via artifact); render a markdown summary table to the $GITHUB_STEP_SUMMARY for one-click visibility on the workflow page. Comment-side (benchmarks-pr-comment.yml): download the artifact, read + strict-validate (`^[0-9]+$`) the PR number, sanitize the CSV (cap at 32 KB, neutralize any triple-backtick sequence so a malicious fork can't escape the code fence and inject arbitrary markdown), then upsert a marker-tagged comment so subsequent runs update in place rather than spam. Report URL: https://github.com/apache/texera/actions/runs/27116212981 With regards, GitHub Actions via GitBox
