This is an automated email from the ASF dual-hosted git repository.
github-merge-queue[bot] pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/texera.git
The following commit(s) were added to refs/heads/main by this push:
new 5d74b610cf chore(pyright-language-service): remove unused hocon-parser
and hoconjs dependencies (#5581)
5d74b610cf is described below
commit 5d74b610cf3c1990f7a70d3445dbdf2e6701f3a0
Author: yangzhang75 <[email protected]>
AuthorDate: Fri Jun 12 01:56:51 2026 -0700
chore(pyright-language-service): remove unused hocon-parser and hoconjs
dependencies (#5581)
<!--
Thanks for sending a pull request (PR)! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
[Contributing to
Texera](https://github.com/apache/texera/blob/main/CONTRIBUTING.md)
2. Ensure you have added or run the appropriate tests for your PR
3. If the PR is work in progress, mark it a draft on GitHub.
4. Please write your PR title to summarize what this PR proposes, we
are following Conventional Commits style for PR titles as well.
5. Be sure to keep the PR description updated to reflect all changes.
-->
### What changes were proposed in this PR?
<!--
Please clarify what changes you are proposing. The purpose of this
section
is to outline the changes. Here are some tips for you:
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
3. If it is a refactoring, clarify what has been changed.
3. It would be helpful to include a before-and-after comparison using
screenshots or GIFs.
4. Please consider writing useful notes for better and faster reviews.
-->
Removes the dead hocon-parser integration from pyright-language-service.
The hoconParser call was removed in #3150 (when the language server
became a standalone microservice) and the leftover import in #3415, but
the two dependencies and the type stub were never cleaned up.
- Delete src/types/hocon-parser.d.ts (type stub for an unused module)
- Remove hocon-parser and hoconjs from package.json
- Regenerate yarn.lock via yarn install
### Any related issues, documentation, discussions?
<!--
Please use this section to link other resources if not mentioned
already.
1. If this PR fixes an issue, please include `Fixes #1234`, `Resolves
#1234`
or `Closes #1234`. If it is only related, simply mention the issue
number.
2. If there is design documentation, please add the link.
3. If there is a discussion in the mailing list, please add the link.
-->
Closes #5442
### How was this PR tested?
<!--
If tests were added, say they were added here. Or simply mention that if
the PR
is tested with existing test cases. Make sure to include/update test
cases that
check the changes thoroughly including negative and positive cases if
possible.
If it was tested in a way different from regular unit tests, please
clarify how
you tested step by step, ideally copy and paste-able, so that other
reviewers can
test and check, and descendants can verify in the future. If tests were
not added,
please describe why they were not added and/or why it was difficult to
add.
-->
- `grep -rn "hocon" pyright-language-service/src` returns nothing
- The TypeScript build passes (`tsc --noEmit -p tsconfig.json`, exit 0)
- No code in the service imports hocon-parser/hoconjs, so this is a pure
dead-code removal
### Was this PR authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this
PR,
please include the phrase: 'Generated-by: ' followed by the name of the
tool
and its version. If no, write 'No'.
Please refer to the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) for
details.
-->
Generated-by: Claude Code (Claude Opus 4.8)
---
pyright-language-service/package.json | 2 --
.../src/types/hocon-parser.d.ts | 27 ----------------------
pyright-language-service/yarn.lock | 10 --------
3 files changed, 39 deletions(-)
diff --git a/pyright-language-service/package.json
b/pyright-language-service/package.json
index 883003160d..09b22b8425 100644
--- a/pyright-language-service/package.json
+++ b/pyright-language-service/package.json
@@ -6,8 +6,6 @@
"type": "module",
"dependencies": {
"express": "4.20.0",
- "hocon-parser": "1.0.1",
- "hoconjs": "1.0.0",
"pyright": "1.1.377",
"typescript": "5.5.4",
"vscode-languageserver": "9.0.1",
diff --git a/pyright-language-service/src/types/hocon-parser.d.ts
b/pyright-language-service/src/types/hocon-parser.d.ts
deleted file mode 100644
index 3b669f0380..0000000000
--- a/pyright-language-service/src/types/hocon-parser.d.ts
+++ /dev/null
@@ -1,27 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied. See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-declare module 'hocon-parser' {
- /**
- * The module itself is callable, accepting a string (HOCON config) and
returning a parsed object.
- */
- function hoconParser(input: string): any;
-
- export = hoconParser;
-}
\ No newline at end of file
diff --git a/pyright-language-service/yarn.lock
b/pyright-language-service/yarn.lock
index 0806c62833..95b324beb8 100644
--- a/pyright-language-service/yarn.lock
+++ b/pyright-language-service/yarn.lock
@@ -404,16 +404,6 @@ hasown@^2.0.0:
dependencies:
function-bind "^1.1.2"
[email protected]:
- version "1.0.1"
- resolved
"https://registry.yarnpkg.com/hocon-parser/-/hocon-parser-1.0.1.tgz#b79b66143999b255e08b673c83291b5e363f0b78";
- integrity
sha512-qMKuQh6pLPQc0gXsl91hAJEjD4JghV1VukO5gKOzjolCnupCbGHpERzMCkZLwVDLq7sL8xR6P4iWhcM1my3HtA==
-
[email protected]:
- version "1.0.0"
- resolved
"https://registry.yarnpkg.com/hoconjs/-/hoconjs-1.0.0.tgz#5fe5c5bc1ab300f734c3aa8b1d8d95d83b4e2ca0";
- integrity
sha512-6jbw9YydPpchxOqrPsIMBZZXGn1F+iSX/iMS5KeBPZfcgj1DfxbjegtzoIHdlyxz24/bCczGGaUCocSXqfNfow==
-
[email protected]:
version "2.0.0"
resolved
"https://registry.yarnpkg.com/http-errors/-/http-errors-2.0.0.tgz#b7774a1486ef73cf7667ac9ae0858c012c57b9d3";
